Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15659
When you type fast in a Bard inside another Bard set, the last few characters can vanish (a short pause is enough). The same problem is for List and Array fields inside a Bard set.
Fields inside a set write straight into the container. About 150 ms later the outer Bard emits the whole field again, so the nested Bard gets a copy of a value it already had. Its own update is still debounced, so it sees a mismatch and rebuilds, losing the newer typing.
Solution
initEditordoes).Unlike #15702, where the outer Bard sent back an outdated copy of the set values, the copy here is up to date. But the nested Bard has already moved past it, because its own update is still debounced so it throws away the newer typing.