Repository navigation
Conversation
This was referenced Oct 20, 2026
Contributor
|
The following capabilities are marked
The following capabilities are marked
These may have been renamed, removed, or never registered. Please update the capability matrix. |
This was referenced Oct 20, 2026
spydon
added this pull request to stack #1799
October 20, 2026 15:08
grdsdev
reviewed
Oct 20, 2026
grdsdev
reviewed
Oct 20, 2026
grdsdev
reviewed
Oct 20, 2026
grdsdev
reviewed
Oct 20, 2026
grdsdev
reviewed
Oct 20, 2026
spydon
force-pushed
the
v3-sync/07-storage
branch
from
October 21, 2026 07:13
def1c3d to
42a096f
Compare
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com> (cherry picked from commit e9f1141)
(cherry picked from commit e6fba08)
(cherry picked from commit 11f6cdf)
Co-authored-by: Leonardo Santiago <leonardo.ribeiro.santiago@gmail.com> (cherry picked from commit 279cc63)
Co-authored-by: Leonardo Santiago <leonardo.ribeiro.santiago@gmail.com> (cherry picked from commit c5e345d)
(cherry picked from commit 05c03dc)
parse_api_error() used status 400 for every unparsable error, so exists() reported a 401 as 400. VectorMatch.metadata now has the same JSON type as VectorObject.metadata, the unused ListIndexesOptions model is removed, and the mock client setup in the unit tests is shared.
An error body that is not valid UTF-8 raised UnicodeDecodeError instead of StorageApiError.
spydon
force-pushed
the
v3-sync/07-storage
branch
from
October 21, 2026 07:46
42a096f to
ff5b71b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks main's storage commits onto v3.
exists()change is here, and the error-parsing part is left to fix(storage3): parse the real API error wire format #1606.Review fixes
exists()raises a 401 as 401 instead of 400.VectorMatch.metadatahas the same JSON type asVectorObject.metadata, and the unusedListIndexesOptionsmodel is removed.StorageApiErrorinstead ofUnicodeDecodeError.Commits
keyoptional (fix(storage): make list_v2 method'skeyoptional #1695) (from e6fba08)Stack
This replaces #1789: main's changes since 6f522d3 are cherry-picked onto v3 one package at a time, so each part can be reviewed on its own. Merge from the bottom up.