You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CI does not type-check the code or check that the installed instance works #326
No type check.@rollup/plugin-typescript reports type errors as warnings unless noEmitOnError is set (rollup.config.mjs#L16-L21), so npm run build exits 0. The tests run through Node's type stripping, which doesn't check types, and ESLint uses the recommended configs, which aren't type-aware. No job or script runs tsc. With a type error added to src/, rollup and ESLint both exit 0 and only npx tsc --noEmit reports it. tsconfig.json also excludes test/ and misc/, so they are never type-checked.
No outcome check in runaction. When setup exits 0, a failed readiness check is only a warning (src/install.ts#L207-L209), and so is a failed cumulative update download (src/install.ts#L139-L143). The runaction job has no step that uses the result, so a change that breaks the SA login or TCP, or a CU that is always skipped, leaves CI green.
Other gaps in the same area:
The build check runs git diff-files --quiet -w (.github/workflows/release.yml#L70). -w ignores whitespace changes, and diff-files ignores new untracked files in lib/.
No job sets timeout-minutes, so a hung job runs for the 6-hour default. On 2026-10-14 the release job on master hung in npm clean-install for 6 hours before it was cancelled (job log).
The matrix never runs ODBC 18, wait-for-ready: false, skip-os-check or install-updates: false.
SQL Server 2008, 2012 and 2014 allow Windows Server 2019 at most (src/versions.ts#L50-L73). GitHub no longer offers a windows-2019 image, so CI can't cover these versions, and on the hosted x64 images the action refuses them unless skip-os-check is set.
Suggested fix:
Add a typecheck script (tsc --noEmit) and run it in the codelint job.
Set noEmitOnError: true in rollup.config.mjs.
Later, type-check test/ and misc/ with a separate tsconfig.
Give the install step an id, and add a step that logs in with the sa-password output. When install-updates is true, also check the update level: SERVERPROPERTY('ProductUpdateLevel') for 2017 and later, and SERVERPROPERTY('ProductLevel') for 2016, whose update is SP3 and not a CU.
Change the build check so it also catches whitespace changes and new files, for example git add --intent-to-add lib && git diff --exit-code.
Add timeout-minutes to each job.
Add matrix entries for ODBC 18 and wait-for-ready: false, and decide what to do about 2008–2014.
Activity