Repository navigation
fix: find the setup logs when Program Files isn't on C:, and print the latest Detail.txt - #351
Merged
Merged
Conversation
The action looked for Summary.txt, Detail.txt and the ERRORLOG files only under the literal path C:/Program Files/Microsoft SQL Server. It uses the ERRORLOG search only when the instance isn't in the registry. Setup writes its logs in the Program Files directory, and installs the instance there by default. On a runner whose Program Files directory is on another drive, the action found none of these files. Build the glob patterns from the ProgramFiles environment variable. Use C:\Program Files when the variable isn't set, and escape any glob characters in it and in the instance name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Setup writes the Detail.txt of each run in a directory named after the start time of the run. That directory is in a directory for each SQL Server version. The action sorted the full paths and used the last one. The version directory comes first in the path, so the sort put the highest version last, even when its run was older. After a failed install, or in debug mode, the action could print an old Detail.txt of another version. Sort by the start time directory instead, and by the full path when two runs have the same start time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dhensby
marked this pull request as ready for review
November 21, 2026 16:09
|
🎉 This PR is included in version 4.1.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setup fails, or in debug mode, the action prints SQL Server setup's
Summary.txtandDetail.txt, and the instance'sERRORLOGfiles. This PR fixes two problems with how it finds them. Both mainly affect self-hosted runners.C:/Program Files/Microsoft SQL Server. Setup writes its logs under the Program Files directory, so on a runner whose Program Files directory is on another drive, a failed install printed no setup logs. TheERRORLOGfiles were still found through the instance's registry entry, but not through the fallback for an instance that isn't registered. The three glob patterns now start from theProgramFilesenvironment variable, withC:\Program Fileswhen it isn't set. Any glob characters in it are escaped.Detail.txt. Setup writes each run'sDetail.txtin a directory named after the run's start time, inside a directory for each SQL Server version. The action sorted the full paths and took the last one. The version directory comes first in the path, so the sort put the highest version last, even when its run was older. On a runner with logs from a later SQL Server version, a failed install printed that version's olderDetail.txt. The action now sorts by the start time directory, and by the full path when two runs have the same start time.Part of #331. The proxy and cache key items follow in separate PRs.
🤖 Generated with Claude Code