Skip to content

connection issues dashboard - #986

Open
ewollesen wants to merge 3 commits into
eric-metric-server-token-fallbackfrom
eric-cid2
Open

connection issues dashboard#986
ewollesen wants to merge 3 commits into
eric-metric-server-token-fallbackfrom
eric-cid2

Conversation

@ewollesen

@ewollesen ewollesen commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • trigger the clinic service to update connection issues
  • add a connectedTime property to data sources

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 4
  • master
  • main
  • develop
  • release.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2386fb5b-2e20-4df0-9851-6d5271ff21ab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ewollesen ewollesen mentioned this pull request Sep 28, 2026
Closed
@ewollesen
ewollesen force-pushed the eric-cid2 branch 3 times, most recently from 3f904cd to 58f1983 Compare September 30, 2026 07:24
lostlevels
lostlevels approved these changes Oct 6, 2026
View reviewed changes
Comment thread clinics/work/connectionissues/factory.go

// NewWorkCreate describes the singleton work item. Creating it again is a no-op, so it
// can be created on every service start.
func NewWorkCreate() (*work.Create, error) {

@lostlevels lostlevels Oct 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Change return to just *work.Create as this function never returns an error.

@ewollesen ewollesen Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't no, but all the other existing NewWorkCreate() functions return (*work.Create, error), which makes things easier on its callers, who don't really care that it never returns an error. I think of it as an unstated interface.

Comment thread notifications/work/claims/processor_test.go
workTest "github.com/tidepool-org/platform/work/test"
)

var _ = Describe("Processor", func() {

@lostlevels lostlevels Oct 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@ewollesen
trigger the clinic service to update connection issues
aabe5ca 
This is done every 5 minutes for now.

BACK-4382
@ewollesen
add a connectedTime property to data sources
51471cb 
Set each time a data source transitions from !connected => connected,
this value will be used by the clinic service to resolve ordering
issues between a clinicians invitation to connect a device, and that
device being connected.

BACK-4252
@ewollesen
notify the clinic service when invite reminders are sent
cfa93cf 
Seven days after a custodial patient is created with an email address,
platform's data service triggers hydrophone to send a device
non-specific reminder to those users, inviting them to connect a cloud
device and/or claim their accounts.

To support the functioning of the connection issues dashboard, the
clinic service needs to know when these reminder emails are sent.

To achieve that goal, the work system worker that sends the reminders
will now also call a clinic endpoint. Failures are logged, but don't
otherwise block the functioning of the worker.

BACK-4579
@ewollesen
ewollesen force-pushed the eric-metric-server-token-fallback branch from 8abc084 to 5dfc731 Compare November 4, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lostlevels lostlevels lostlevels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ewollesen @lostlevels