Repository navigation
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
No issue filed. Same change as #4502, one version later.
rusqlite 0.42.0 requires
libsqlite3-sys ^0.40, so it can't be in the same dependency graph as sqlx (<0.40.0on main):To reproduce: a crate depending on
sqlx(any features) andrusqlite = "0.42", thencargo generate-lockfile. With this branch it resolves and builds.Is this a breaking change?
No. 0.40.0 only differs from 0.39.1 in the bundled SQLCipher version (4.20.0). The SQLite test suite passes locally against 0.40.0, bundled and unbundled, and 0.30.1 still builds.
It would be great if this could make it into 0.9.1 (#4517).