Repository navigation
Fix macros imported in the body of a for loop not being available after it - #5010
Open
nicolas-grekas wants to merge 1 commit into
Open
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
stof
reviewed
Oct 20, 2026
| @@ -0,0 +1,16 @@ | |||
| --TEST-- | |||
| "for" tag keeps the macros imported in its body available after the loop | |||
Member
There was a problem hiding this comment.
Should this test be added in 3.x as well ?
Contributor
Author
There was a problem hiding this comment.
done in #5011; I split the fixture so that the 3.x one merges up as is, the recursive case being 4.x only
nicolas-grekas
force-pushed
the
for-loop-macro-imports
branch
from
October 20, 2026 12:11
5680cf1 to
7c18a66
Compare
stof
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 4.x compiles the body of a
forloop in a closure, the macros imported in the body were only available inside the loop. Using them after the loop threw an error saying that the template body wasn't rendered, while this works on 3.x. The closure now uses the macros of the enclosing scope by reference.