Repository navigation
Conversation
A document with `<base href="/sub/">` produced scheme-less links such as `/sub/page.html`, while the same document without a `<base>` element produced absolute links. Resolve the base href with urljoin so both paths agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2550.
<base href>is now resolved against the page URL withurljoin, so a relative base (root-relative or document-relative) produces absolute links instead of scheme-less strings such as/sub/page.html. Absolute base values behave exactly as before.List of files changed and why
crawl4ai/content_scraping_strategy.py- resolvebase_hrefwithurljoin(url, base_href)before it is used to normalise links.tests/test_base_href_relative_links.py- new regression tests for root-relative, document-relative, absolute and missing<base>values.How Has This Been Tested?
Without the change the two relative-base tests fail (
/sub/page.html,sub/page.html); with it they returnhttps://example.com/sub/page.htmlandhttps://example.com/app/sub/page.html.Checklist: