Repository navigation
fix(cli): exit non-zero when the crawl profile does not exist - #2568
Open
SoulmatelynchVFX wants to merge 1 commit into
Open
SoulmatelynchVFX wants to merge 1 commit into
SoulmatelynchVFX wants to merge 1 commit into
Conversation
crwl crawl with an unknown --profile printed the error and returned from the callback, so the process exited 0 with no output written. Scripts checking the exit status treated that as a successful crawl. The sibling profile commands already exit 1 for the same condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crwl crawlon a profile that does not exist prints the error and then returns normally, so the process exits 0:out.mdis never written and nothing was crawled, but the exit status says success, so a script that checks$?cannot tell this apart from a completed crawl.The same file already exits 1 for the equivalent case in
crwl profiles delete(Profile not found:→sys.exit(1)), so this looks like an oversight rather than an intended contract.Change: the early
returnin the profile lookup becomessys.exit(1), covering both branches (profile missing / no profiles at all). Both entry points route throughcrawl_cmd(crwl crawlandcrwl <url> -p <name>).Test:
tests/cli/test_cli.py::TestCLIBasics::test_missing_profile_exits_non_zerostubsBrowserProfilerand asserts the runner sees exit code 1.