Skip to content

fix: support libc interposition - #16383

Draft
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:libc-interposition
Draft

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:libc-interposition

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Context: #14946

@oech3

oech3 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Disagree. We should fix broken consumers instead. We don't have too many consumers.
Upstream of fakeroot is debian and it is still actively maintained.

- name: Run safe traversal verification
run: ./util/check-safe-traversal.sh

test_libc_interposition:

@oech3 oech3 Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not delete this (or rewrite in Rust). The solution for this is not changing backend only.

@codspeed

codspeed Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 18.63%

2 warnings

⚠️ 68 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 2 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

❌ 2 regressed benchmarks
✅ 117 untouched benchmarks
⏩ 360 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ socket_addrs_direct[100000] 104.8 µs 132.7 µs -20.99%
❌ hostname_ip_lookup[100000] 155.7 µs 185.9 µs -16.2%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:libc-interposition (1927964) with main (c44859c)2

Open in CodSpeed

Footnotes

  1. 360 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (36079aa) during the generation of this report, so c44859c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze
xtqqczze force-pushed the libc-interposition branch 2 times, most recently from f54059b to 54a2d4e Compare November 15, 2026 18:07
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

/rerun CICD

2 similar comments
@xtqqczze

Copy link
Copy Markdown
Collaborator Author

/rerun CICD

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

/rerun CICD

@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.51 MB (+128 KB, +0.08%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

/rerun CICD
/rerun make

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants