Repository navigation
feat(ui): sent isAbort, isDisconnect, isError in useChat onFinish callback - #8364
Merged
Merged
Conversation
lgrammel
marked this pull request as ready for review
September 1, 2025 09:24
nicoalbanese
approved these changes
Sep 1, 2025
This was referenced Aug 10, 2026
6 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Chat.onFinishwas called in many different cases and it is unclear how it related to finished assistant responses.Summary
Add
isAbort,isDisconnect,isErrortoChat.onFinishcallback.Implemented in the same callback to prevent breaking behavior changes.
Manual Verification
examples/nextwith build/start and force kill node server while request is in progress, check callback values in consoleexamples/nextand abort request, check callback values in consoleTasks
Future Work