Repository navigation
[test] Avoid port collisions in concurrent keep-alive tests - #100537
Open
unstubbable wants to merge 1 commit into
Open
unstubbable wants to merge 1 commit into
unstubbable wants to merge 1 commit into
Conversation
The suite bound every mock server to port 44001, so the concurrent runs in #100525 could fail with EADDRINUSE. Each run now uses an OS-assigned port and passes its server URL to the fixture. The suite also awaits server shutdown.
unstubbable
added this pull request to stack #100539
October 21, 2026 18:50
github-actions
Bot
added
created-by: Next.js team
Contributor
Tests PassedCommit: 2bc7645 |
unstubbable
changed the title
unstubbable
marked this pull request as ready for review
October 21, 2026 19:17
mischnic
approved these changes
Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suite bound every mock server to port 44001, so the concurrent runs in #100525 could fail with EADDRINUSE. Each run now uses an OS-assigned port and passes its server URL to the fixture.
The suite also awaits server shutdown.