Skip to content

feat(js-runtime): support powerpc64 and powerpc64le #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pkubaj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(js-runtime): support powerpc64 and powerpc64le #3182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions crates/vp_js_runtime/src/platform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ pub enum Os {
pub enum Arch {
X64,
Arm64,
Ppc64,
Ppc64le,
}

impl Platform {
Expand Down Expand Up @@ -84,6 +86,8 @@ impl Arch {
/// # Supported architectures
/// - `x86_64` (`target_arch = "x86_64"`)
/// - ARM64/AArch64 (`target_arch = "aarch64"`)
/// - PowerPC64 big-endian (`target_arch = "powerpc64"`, `target_endian = "big"`)
/// - PowerPC64 little-endian (`target_arch = "powerpc64"`, `target_endian = "little"`)
///
/// Compilation will fail on unsupported architectures.
#[must_use]
Expand All @@ -96,10 +100,22 @@ impl Arch {
{
Self::Arm64
}
#[cfg(not(any(target_arch = "x86_64", target_arch = "aarch64")))]
#[cfg(all(target_arch = "powerpc64", target_endian = "big"))]
{
Self::Ppc64
}
#[cfg(all(target_arch = "powerpc64", target_endian = "little"))]
{
Self::Ppc64le
}
#[cfg(not(any(
target_arch = "x86_64",
target_arch = "aarch64",
target_arch = "powerpc64"
)))]
{
compile_error!(
"Unsupported CPU architecture. vp_js_runtime only supports x86_64 and aarch64."
"Unsupported CPU architecture. vp_js_runtime only supports x86_64, aarch64, and powerpc64."
)
}
}
Expand All @@ -110,6 +126,8 @@ impl fmt::Display for Arch {
match self {
Self::X64 => write!(f, "x64"),
Self::Arm64 => write!(f, "arm64"),
Self::Ppc64 => write!(f, "ppc64"),
Self::Ppc64le => write!(f, "ppc64le"),
}
}
}
Expand All @@ -136,6 +154,8 @@ mod tests {
let cases = [
(Platform { os: Os::Linux, arch: Arch::X64 }, "linux-x64"),
(Platform { os: Os::Linux, arch: Arch::Arm64 }, "linux-arm64"),
(Platform { os: Os::Linux, arch: Arch::Ppc64 }, "linux-ppc64"),
(Platform { os: Os::Linux, arch: Arch::Ppc64le }, "linux-ppc64le"),
(Platform { os: Os::Darwin, arch: Arch::X64 }, "darwin-x64"),
(Platform { os: Os::Darwin, arch: Arch::Arm64 }, "darwin-arm64"),
(Platform { os: Os::Windows, arch: Arch::X64 }, "windows-x64"),
Expand Down
6 changes: 6 additions & 0 deletions crates/vp_js_runtime/src/providers/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,8 @@ impl JsRuntimeProvider for NodeProvider {
let arch = match platform.arch {
crate::platform::Arch::X64 => "x64",
crate::platform::Arch::Arm64 => "arm64",
crate::platform::Arch::Ppc64 => "ppc64",
crate::platform::Arch::Ppc64le => "ppc64le",
};
// On musl targets, append "-musl" to match unofficial-builds filename pattern
// e.g. "linux-x64-musl" instead of "linux-x64"
Expand Down Expand Up @@ -733,6 +735,8 @@ mod tests {
let cases = [
(Platform { os: Os::Linux, arch: Arch::X64 }, "linux-x64"),
(Platform { os: Os::Linux, arch: Arch::Arm64 }, "linux-arm64"),
(Platform { os: Os::Linux, arch: Arch::Ppc64 }, "linux-ppc64"),
(Platform { os: Os::Linux, arch: Arch::Ppc64le }, "linux-ppc64le"),
(Platform { os: Os::Darwin, arch: Arch::X64 }, "darwin-x64"),
(Platform { os: Os::Darwin, arch: Arch::Arm64 }, "darwin-arm64"),
(Platform { os: Os::Windows, arch: Arch::X64 }, "win-x64"),
Expand All @@ -742,6 +746,8 @@ mod tests {
let cases = [
(Platform { os: Os::Linux, arch: Arch::X64 }, "linux-x64-musl"),
(Platform { os: Os::Linux, arch: Arch::Arm64 }, "linux-arm64-musl"),
(Platform { os: Os::Linux, arch: Arch::Ppc64 }, "linux-ppc64-musl"),
(Platform { os: Os::Linux, arch: Arch::Ppc64le }, "linux-ppc64le-musl"),
(Platform { os: Os::Darwin, arch: Arch::X64 }, "darwin-x64"),
(Platform { os: Os::Darwin, arch: Arch::Arm64 }, "darwin-arm64"),
(Platform { os: Os::Windows, arch: Arch::X64 }, "win-x64"),
Expand Down
Loading