Repository navigation
feat: vortex-filecheck, FileCheck-style checks of Vortex encodings - #11544
Draft
joseph-isaacs wants to merge 2 commits into
Draft
joseph-isaacs wants to merge 2 commits into
joseph-isaacs wants to merge 2 commits into
Conversation
joseph-isaacs
force-pushed
the
ji/sleepy-albattani-o2d43n
branch
from
November 17, 2026 20:04
2f8e470 to
e1f0da8
Compare
Add a `vortex-filecheck` crate that renders each flat layout of a Vortex file as a text unit (layout path header plus the array encoding tree, decoded without decompressing) and checks it with `filecheck` crate directives, which match partially and in order like LLVM FileCheck. Check files add `files: <regex>` (the Vortex files they apply to, relative to a searched root) and `units: <glob>` (check the following directives against every matching unit). Parsing is strict: every line must be blank, a `#` comment, or a directive at the start of the line, so misspellings fail instead of silently never running, and a section whose glob matches no unit fails. Failure reports name the directive that missed, or the trailing `not:` directives that may have matched, with the match trace around it. `check_tree` checks every matching file under a root, for test suites, benchmark runners and data generators. `vx filecheck <file> [<check>]` prints a file's dump or checks it. The SLT runner turns each `.check` file under `slt/` into an `slt::filecheck::*` trial rooted at `slt/`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBDxK1z3cP4gAzkh8c8 Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Check the encodings `data-gen` writes for TPC-H nation: a sequence key, FSST names and comments, a dictionary layout for the region key, and a zone map per column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBDxK1z3cP4gAzkh8c8 Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/sleepy-albattani-o2d43n
branch
from
November 17, 2026 20:09
e1f0da8 to
7fedfe6
Compare
joseph-isaacs
changed the base branch from
develop
to
ji/slt-tpch-fixture-names
November 17, 2026 20:10
This was referenced Nov 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a FileCheck-style system for checking the array encoding trees of Vortex files, so tests can require specific encodings, or rule out bad ones, in generated files. A compressor change that re-encodes test or benchmark data then fails a check instead of only showing up as a benchmark swing.
This is the second PR in a stack:
vx filecheck, the SLT hook, and one check over a small TPC-H table.Changes
New
vortex-filecheckcrate., chunks as[i], and other children (data,zones,values,codes) with/.filecheckdirectives (check:,nextln:,not:,regex:, …), which match partially and in order. The crate adds two more:files: <regex>names the Vortex files a check applies to, as a whole-path regex relative to the searched root.units: <glob>checks the directives after it against every matching unit. A glob that matches no unit fails.#comment, or a directive at the start of the line. These are errors with a line number:filecheckwould silently ignorecheck:foo);units:sections with no directives;not:after the last positive match matches, filecheck itself reports nothing, so the report names thosenot:directives and shows the line that matched:check_tree(session, root, check, …)checks every.vortexfile underrootthat the check'sfiles:regexes match, and fails if none match. It is meant for test suites, benchmark runners and data generators.load_units+run_checkscheck a single file.filecheck0.5. Its license (Apache-2.0 WITH LLVM-exception) is already allowed bydeny.toml; it only depends onregexandthiserror, both already in the lockfile.vx filecheck(vortex-tui)vx filecheck <file>prints the dump, to help write checks.vx filecheck <file> <check>checks the file.--exclude <glob>skips units without reading them.--metadata,--nbytes,--buffersand--statsadd detail to the dump, and--explainprints the full match trace.vortex-sqllogictest.checkfile underslt/becomes anslt::filecheck::*trial that runscheck_treerooted atslt/. It is ignored when its suite's generated data is absent, like the suite's.sltfiles.vx filecheck … --explaincommand for each failing file.slt/tpch/filecheck/nation.checkchecks thatdata-genwrites TPC-Hnationwith:Testing
cargo test -p vortex-filecheckcheck_treefile selection and errorscargo clippy -p vortex-filecheck --all-targets --all-features -- -D warningscargo +nightly-2026-11-13 fmtvx filecheck slt/tpch/data/nation.vortex slt/tpch/filecheck/nation.checkdata-genoutputcargo test -p vortex-sqllogictestAPI Changes
Additive only:
vortex-filecheck;vx filechecksubcommand.🤖 Generated with Claude Code
https://claude.ai/code/session_01UeniBDxK1z3cP4gAzkh8c8