Repository navigation
Conversation
DynamicComparisonExpr::scalar() returns None until the value is known, so code outside vortex-array could not tell which dtype a dynamic comparison expects. Add DynamicComparisonExpr::dtype(). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SMtfpBcKnfP3CkWWQL6mit Signed-off-by: William Beckler <wbeckler@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamicComparisonExpr#11550DynamicComparisonExprexposes its operator, its default and the current value, but not the dtype of the value, andscalar()returnsNoneuntil a value is known. Code outsidevortex-arraytherefore cannot tell which dtype a dynamic comparison expects.#11523 needs this: the DuckDB converter gives a dynamic comparison the dtype of the zoned timestamp column it filters, and without the accessor it rebuilds every such comparison instead of only the ones that differ.
Changes
DynamicComparisonExpr::dtype()returns the dtype of the dynamic value.This PR does not change
vortex-duckdb. Using the accessor there depends on #11523, so I will follow up once both are in.Tests
cargo test -p vortex-array --libfiltered toscalar_fn::fns::dynamic(8 passed), clippy with-D warningsonvortex-array, and fmt on the pinned nightly. I did not run the wholevortex-arraysuite.AI assistance
Written by Claude Code (Claude Fable 5.2), an AI coding agent, working at my direction. It also ran the checks listed above and opened this PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SMtfpBcKnfP3CkWWQL6mit