Skip to content

Use canonical widths in decimal compute kernels - #11573

Draft
connortsui20 wants to merge 1 commit into
ct/decimal-value-checkfrom
ct/decimal-remove-width-workarounds
Draft

connortsui20 wants to merge 1 commit into
ct/decimal-value-checkfrom
ct/decimal-remove-width-workarounds

Conversation

@connortsui20

@connortsui20 connortsui20 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Two canonical decimal arrays with the same precision and scale now share an integer width. Comparisons, patching, interleave, row encoding, and builder append can read those buffers directly. Arithmetic still selects its working and result widths independently, and DecimalByteParts still converts values when splitting a high-precision decimal into integer parts.

The public DecimalType::is_compatible_decimal_value_type helper is removed. Use DecimalDType::canonical_values_type() to obtain the required width.

Stacked on #11572

@connortsui20 connortsui20 added the changelog/break A breaking API change label Nov 17, 2026
@connortsui20
connortsui20 force-pushed the ct/decimal-remove-width-workarounds branch from a98f799 to e8220ec Compare November 17, 2026 21:06
@connortsui20
connortsui20 force-pushed the ct/decimal-remove-width-workarounds branch from e8220ec to b1038e4 Compare November 17, 2026 21:07
@connortsui20
connortsui20 force-pushed the ct/decimal-remove-width-workarounds branch from b1038e4 to 7e41269 Compare November 17, 2026 21:38
@connortsui20
connortsui20 force-pushed the ct/decimal-remove-width-workarounds branch 2 times, most recently from 3fee585 to dd20bd0 Compare November 17, 2026 22:36
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
connortsui20 force-pushed the ct/decimal-remove-width-workarounds branch from dd20bd0 to af1179e Compare November 17, 2026 22:38

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant