Repository navigation
fix(runtime-vapor): run app mounted hooks after hydration ends - #15753
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the 鈿欙笍 Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Size ReportBundles
Usages
|
|
The continuous-release failure is a pkg.pr.new server error during publish (500, then 404). It is not caused by this change. |
When
createVaporSSRApphydrates a component that changes state inonMounted, av-forclass binding keeps a stale class on the previous item.hydrateAppcallsflushOnAppMount()insidewithHydration(), so mounted hooks and the effects they trigger run whileisHydratingis still true. ThecreateSelectorwatcher then callssetClasson the old item, which only checks for a mismatch during hydration and never patches the DOM.flushOnAppMount()now runs afterwithHydration()returns, so mounted hooks see a finished hydration, as they do on a regular mount.close #15752