Repository navigation
Conversation
All of these pointed into the frozen `dev` branch, which still serves pre-TypeScript 2.6.14 content, so they returned HTTP 200 while showing readers the wrong code. Several also targeted paths that no longer exist on `main`: - `packages/vue-server-renderer` was renamed to `packages/server-renderer` - `flow/compiler.js` was deleted in the TypeScript port; `ModuleOptions` now lives in `src/types/compiler.ts` and `SFCDescriptor` in `packages/compiler-sfc/src/parseComponent.ts` - `entry-compiler.js` is now `entry-compiler.ts` - `entry-server-renderer.js` no longer exists; the server renderer sources moved to `packages/server-renderer/src`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
mainbranch for v2.x (or to a previous version branch)Other information:
Follow-up to #13192 / #13187 — a few more dead documentation links.
These are easy to miss with a link checker because they all point into the
devbranch, which is frozen at 2022-07-13 (still
2.6.14, before the TypeScriptport). They return HTTP 200 while serving readers content that no longer matches
main. Four of them also reference paths that no longer exist at all:tree/dev/packages/vue-server-rendererpackages/server-rendererblob/dev/flow/compiler.js#L47-L59flow/was deleted in the TS port;ModuleOptionsnow lives insrc/types/compiler.tsblob/dev/flow/compiler.jsSFCDescriptornow lives inpackages/compiler-sfc/src/parseComponent.tstree/dev/src/platforms/web/entry-compiler.jsentry-compiler.tsblob/dev/src/platforms/web/entry-server-renderer.jsmain; the SSR sources are underpackages/server-renderer/srcThe remaining changes just retarget
dev→main. I verified every replacementpath resolves in the current tree. The two "flow declarations" link texts are
relabelled to "type declarations" to match.
Not included, happy to add if you'd prefer them in the same PR:
.github/PULL_REQUEST_TEMPLATE.mdlines 3 and 29 have the same staleblob/dev/.github/CONTRIBUTING.mdlinks..github/CONTRIBUTING.mdis stale in a bigger way — it still describes Flow,Karma/Jasmine, Nightwatch, ESLint,
npm run commit, andsrc/server/src/sfc. That felt like a separate discussion rather than a link fix.README.mdare pinned todevand there isno
.circleciconfig onmain, so they report a 2022 build state. Left alonesince that is a maintainer call.