Repository navigation
fix: reject non-canonical RLP in fromRlp - #5513
Merged
Merged
Conversation
`fromRlp` accepted a single byte below `0x80` behind a length prefix and long-form lengths that fit a shorter prefix, so `parseTransaction` and `recoverTransactionAddress` returned the same fields and signer for a malleated payload whose hash differs from the canonical one and which nodes reject. Throw `RlpNonCanonicalError` for both, matching ox's `Rlp.NonCanonicalError` and geth's RLP decoder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: jxom <jake@tempo.xyz>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1d4c0-1149-7328-8cfa-9ab8107d0f37 Co-authored-by: jxom <jake@tempo.xyz>
🦋 Changeset detectedLatest commit: 6960b19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Amp-Thread-ID: https://ampcode.com/threads/T-01a1d4c0-1149-7328-8cfa-9ab8107d0f37 Co-authored-by: jxom <jake@tempo.xyz>
Contributor
|
Published pnpm add viem@pr-5513
pnpm add viem@0.0.0-pr-5513-ce0e56b |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #5506 by @gomesalexandre. Their commit is cherry-picked unchanged, with authorship preserved.
fromRlpaccepted non-canonical encodings, so a payload could decode to the same value under a different hash. It now throwsRlpNonCanonicalErrorfor:0x80wrapped in a length prefix (0x8100,0x817f)0xb837…,0xf800)0xb900ff…,0xba000100…)These match Yellow Paper appendix B, geth's
ErrCanonSize/ErrNonCanonicalSize, and ox'sRlp.NonCanonicalError. viem keeps its own decoder because ox'sRlp.todoes not check for trailing bytes, list overruns, or depth.On top of the cherry-pick, this PR adds TSDoc to the new public error.
Verification
recoverTransactionAddressreturns the original sender.fromRlp,parseTransaction, andindextests pass, Biome is clean, andtsc -b srcpasses.