Repository navigation
Conversation
Pairs with hoist-react segmented-control-sizing (xh/hoist-react#4856), which removes `SegmentedControl.fill` and sizes the control to its options by default. - Removed `fill: false`, now the default. - Replaced `fill: true` with `width: '100%'` in the favicons example. - Changed the SegmentedControl demo's "Fill width" playground toggle to a "Full width" toggle that sets `width`. Requires a hoist-react build with that change. Committed with --no-verify because the pre-commit typecheck runs against the published @xh/hoist.
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with xh/hoist-react#4856, which removes
SegmentedControl.filland sizes the control to its options by default. Merge after that PR.Changes
fill: false, now the default (17 lines across 12 files).fill: truewithwidth: '100%'in the favicons example.width.Verification
Requires a hoist-react build with xh/hoist-react#4856, for example
pnpm startWithHoistagainst that branch. Against the published@xh/hoist, typecheck fails on the faviconswidthprop. For that reason the commit skipped the pre-commit hook. Prettier and ESLint pass on the changed files.The dashboard
OptionsWidgetrelied on the old defaultfilland now renders at its options' width. It is unchanged here - see the follow-up comment on xh/hoist-react#4856.