Add Support for getLineHeightFactor() and setLineHeightFactor() functions #22

Activity

1. yGuy commented on Jun 11, 2019

   

   yGuy

   on Jun 11, 2019

   Member

   More actions

   These functions have been added only recently and we will have to merge with the master to get these. What's the use-case for these functions?
2. yGuy

   added

   needs-infoThis issue is on hold, until more information becomes available.This issue is on hold, until more information becomes available.

   on Jun 11, 2019
3. Fadiabb commented on Jun 11, 2019

   

   Fadiabb

   on Jun 11, 2019

   Last edited by Fadiabb

   Author

   More actions

   setLineDash() : we use it to set the dash pattern for upcoming lines (line,circle,......)
   getLineHeighFactor(): we use it in a function to calculate the text height of many lines text
4. yGuy commented on Jun 11, 2019

   

   yGuy

   on Jun 11, 2019

   Member

   More actions

   The next time we merge with master (if this is still feasible), the functions will be added. There is currently no roadmap for this, but it will happen sooner or later.
5. yGuy

   added

   enhancement

   and removed

   needs-infoThis issue is on hold, until more information becomes available.This issue is on hold, until more information becomes available.

   on Jun 11, 2019
6. bernhardreiter commented on Jul 2, 2019

   

   bernhardreiter

   on Jul 2, 2019

   More actions

   Here is a patch to add setLineDash() against 3561de8 (current master) which works for me:

   diff --git a/jspdf.js b/jspdf.js
   index 9a8cc01..7175b77 100644
   --- a/jspdf.js
   +++ b/jspdf.js
   @@ -3942,6 +3942,33 @@ var jsPDF = (function(global) {
        };
    
        /**
   +     * Sets the dash pattern for upcoming lines.
   +     *
   +     * To reset the settings simply call the method without any parameters.
   +     * @param {array} dashArray The pattern of the line, expects numbers.
   +     * @param {number} dashPhase The phase at which the dash pattern starts.
   +     * @function
   +     * @instance
   +     * @returns {jsPDF}
   +     * @memberOf jsPDF
   +     * @name setLineDash
   +     */
   +    API.setLineDash = function(dashArray, dashPhase) {
   +      dashArray = dashArray || [];
   +      dashPhase = dashPhase || 0;
   +
   +      if (isNaN(dashPhase) || !Array.isArray(dashArray)) {
   +        throw new Error('Invalid arguments passed to setLineDash.');
   +      }
   +
   +      dashArray = dashArray.map(function (x) {return (x * k).toFixed(3)}).join(' ');
   +      dashPhase = parseFloat((dashPhase * k).toFixed(3));
   +
   +      out('[' + dashArray + '] ' + dashPhase + ' d');
   +      return this;
   +    };
   +
   +    /**
         * Sets the stroke color for upcoming elements.
         *
         * Depending on the number of arguments given, Gray, RGB, or CMYK

   Shall I prepare a pull request?
   (I've not included the test cases, because I haven't checked what the new place for them would be. I did slight change the Error message to end with a fullstop and to remove the jsPDF. part.)
7. HackbrettXXX commented on Jul 2, 2019

   

   HackbrettXXX

   on Jul 2, 2019

   Member

   More actions

   There is already a setLineDashPattern method. We can probably just delegate to it. Also, in "advanced" API mode we should not scale the values by k.
8. bernhardreiter commented on Jul 3, 2019

   

   bernhardreiter

   on Jul 3, 2019

   More actions

   The upcoming jsPDF with parallax@849ce007 now already accepts setLineDashPattern() as part of getting more compatible, so implementing setLineDash is not necessary anymore.
9. bernhardreiter commented on Jul 3, 2019

   

   bernhardreiter

   on Jul 3, 2019

   Last edited by bernhardreiter

   More actions

   Thanks for the hint about setLineDashPattern, I've created a new issue #23.
   So remaining here (in this issue) is the support for settting and getting the LineHeightFactor.

   @Fadiabb please edit the title to Support getLineHeightFactor() and setLineHeightFactor() next time you are looking into this.
10. Fadiabb

    changed the title [-]Add Support for some jspdf functions[/-] [+]Add Support for getLineHeightFactor() and setLineHeightFactor() functions[/+] on Dec 3, 2019