Repository navigation
Inconsistent overridden method #2377
Description
Zarr version
v3
Installation
sources
Description
These methods of abstract base class Store are non-async:
Child classes LocalStore, LoggingStore, RemoteStore, MemoryStore, ZipStore override these functions as async. Take the example of ZipStore:
Is that on purpose? I think async is part of the method signature and should be added to the base class.
Activity
jhamman commentedon Oct 15, 2024
This is intentional but I don't remember all the details. It has to do with how Python does abstract methods for async generators IIRC. If there is a better solution, I'd be happy to see one come forward though.
DimitriPapadopoulos commentedon Oct 15, 2024
I'm afraid I don't have much experience with
asyncmethods, so I cannot help much.It's just that:
asyncto the method definition - and perhaps add an emptyyieldso that linters are happy. See for example How to properly type class abstract async methods and override them in child classes microsoft/pyright#4741.https://app.deepsource.com/gh/DimitriPapadopoulos/zarr-python/issue/PYL-W0236/occurrences
I could start a PR where I try to add
asyncto the abstract base class methods, so we can see what happens. How does it sound?jhamman commentedon Oct 15, 2024
Go for it @DimitriPapadopoulos!