Repository navigation
do we need the ChunkCoords type #3373
Description
IMO ChunkCoords is not really a usability upgrade over tuple[int, ...], and we use ChunkCoords for lots of non-chunk-coordinate related stuff, like shapes.
I propose removing ChunkCoords in favor of tuple[int, ...]. If we have places in the codebase where we want to carefully distinguish between tuples of ints with different meanings, maybe we can use a NewType for this.
Reacted by Tom Nicholas
Activity
TomNicholas commentedon Aug 13, 2025
I also found this really confusing and was intending to complain about it. But I'm not sure if it would be better to just have separate types that both represent
tuple[int, ...].dcherian commentedon Aug 13, 2025
Yes NewType is definitely the way. The
tuple[int, ...]applies to shard shape, chunk shape, and array shape, so a few NewType could be a better approach