Repository navigation
fix: handle longlong arrays on Linux and macOS correctly - #4589
Merged
Merged
Conversation
github-actions
Bot
added
the
needs release notes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
==========================================
- Coverage 94.84% 94.84% -0.01%
==========================================
Files 96 96
Lines 13998 13997 -1
==========================================
- Hits 13276 13275 -1
Misses 722 722
🚀 New features to boost your workflow:
|
github-actions
Bot
removed
the
needs release notes
Contributor
|
hi @radoering, thanks for this fix. do you mind if I push some additional changes on top of this? then we can get it in quickly |
Contributor
Author
|
@d-v-b I do not mind at all. I am only interested in a solution - no matter whose solution it is. 🙂 |
The `kind` and `itemsize` comparison raised `AttributeError` for inputs without those attributes, and accepted any object that had them. Both `from_native_dtype` and the registry's `match_dtype` then failed with the wrong error, so check for a NumPy dtype first. Also correct the docstring's class order, cover macOS in the docstring and changelog entry, and describe the check accurately in the error message. Assisted-by: ClaudeCode:claude-opus-5-5
d-v-b
changed the title
d-v-b
approved these changes
Nov 2, 2026
d-v-b
enabled auto-merge (squash)
November 2, 2026 14:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Similar issue as #3151 and #3797 - this time, for a change, on Linux and not on Windows.
For reviewers
Picking up #3797 (comment), I tried a more general solution this time. If you do not like this solution, we can do the same as in #3151 and #3797 and override the method in the subclasses.
Author attestation
TODO
docs/user-guide/*.mdchanges/