Skip to content

Update name of runtime to be downloaded - #59

Merged
probonopd merged 4 commits into
mainfrom
probonopd-patch-1
Aug 5, 2024
Merged

probonopd merged 4 commits into
mainfrom
probonopd-patch-1

Conversation

@probonopd

@probonopd probonopd commented Aug 5, 2024 •

Copy link
Copy Markdown
Member

Quick fix to partly address #58.

The real reason, I think, is to not use the downloading mechanism as it is way too fragile:

  • The repo name might change
  • The filename might change

Errors caused by this should happen at build time, when developers can fix it, rather than at run time, when users are affected.

The bare minimum needed, I think, is that changes in type2-runtime need to trigger a build of appimagetool. So that any potential issues are seen by developers immediately.

@probonopd
probonopd requested a review from TheAssassin August 5, 2024 08:42
@probonopd

Copy link
Copy Markdown
Member Author

i686 file is missing, pending on

@probonopd
probonopd merged commit 993b8c3 into main Aug 5, 2024
@probonopd
probonopd deleted the probonopd-patch-1 branch August 5, 2024 10:11
probonopd pushed a commit to AppImage/type2-runtime that referenced this pull request Aug 5, 2024
We don't want the FUSE version as part of the filename.
I will revert AppImage/appimagetool#59 as well.
probonopd added a commit that referenced this pull request Aug 5, 2024
@TheAssassin

Copy link
Copy Markdown
Member

Please stop merging without a review.

probonopd added a commit that referenced this pull request Aug 5, 2024
Reverts #59 because the name of the runtime was renamed to its original name in AppImage/type2-runtime#57 again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants