Repository navigation
Update name of runtime to be downloaded - #59
Merged
Merged
Conversation
Quick fix to partly address https://github.com/FreeCAD/FreeCAD-Bundle/issues/102
Member
Author
|
i686 file is missing, pending on |
probonopd
pushed a commit
to AppImage/type2-runtime
that referenced
this pull request
Aug 5, 2024
We don't want the FUSE version as part of the filename. I will revert AppImage/appimagetool#59 as well.
Member
|
Please stop merging without a review. |
probonopd
added a commit
that referenced
this pull request
Aug 5, 2024
Reverts #59 because the name of the runtime was renamed to its original name in AppImage/type2-runtime#57 again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix to partly address #58.
The real reason, I think, is to not use the downloading mechanism as it is way too fragile:
Errors caused by this should happen at build time, when developers can fix it, rather than at run time, when users are affected.
The bare minimum needed, I think, is that changes in type2-runtime need to trigger a build of appimagetool. So that any potential issues are seen by developers immediately.