Skip to content

Remove superfluous -type3 suffix from artifacts - #57

Merged
probonopd merged 1 commit into
mainfrom
rename-artifacts
Aug 5, 2024
Merged

probonopd merged 1 commit into
mainfrom
rename-artifacts

Conversation

@TheAssassin

Copy link
Copy Markdown
Member

fuse2 is no longer supported. I also fixed a few oversights from its removal.

Fixes AppImage/appimagetool#58.

@TheAssassin
TheAssassin requested a review from probonopd August 5, 2024 18:56
fuse2 is no longer supported. I also fixed a few oversights from its
removal.
@github-actions

github-actions Bot commented Aug 5, 2024

Copy link
Copy Markdown

Build for testing:
artifacts
Use at your own risk.

@probonopd

probonopd commented Aug 5, 2024 •

Copy link
Copy Markdown
Member

While I agree that the suffix should be removed (for another reason though), AppImage/appimagetool@993b8c3 would need to be reverted then as well. These things must currently be done in sync or everything will break (like it was this morning). Hence I would like to trigger appiamgetool builds every time the runtime changes.

The reason that I believe the suffix should be removed is that we don't want the name to change when we will use a later version internally at a later point in time.

@probonopd
probonopd merged commit cec4c1a into main Aug 5, 2024
@probonopd
probonopd deleted the rename-artifacts branch August 5, 2024 19:58
@TheAssassin

Copy link
Copy Markdown
Member Author

Please stop randomly pushing without reviews.

@probonopd

Copy link
Copy Markdown
Member

I have reviewed this, then merged it.

@probonopd

Copy link
Copy Markdown
Member

Since i have merged this, I also have to merge AppImage/appimagetool#62 without delay, or else appimagetool will be in a broken state.

@TheAssassin

Copy link
Copy Markdown
Member Author

I was referring to your PR in appimagetool. I'm still trying to figure out the slight mess created today while I was at work.

As said before, we can add tests accordingly. Triggering builds randomly across repositories is insufficient and doesn't really test what we want to know. Also, it unnecessarily delays the build process.

probonopd added a commit to AppImage/appimagetool that referenced this pull request Aug 5, 2024
Reverts #59 because the name of the runtime was renamed to its original name in AppImage/type2-runtime#57 again
@probonopd

Copy link
Copy Markdown
Member

Triggering builds

Let's discuss that topic in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

appimagetool has old URL, does not check runtime size nor HTTP status code

2 participants