Skip to content

Trigger appimagetool build - #50

Closed
probonopd wants to merge 5 commits into
mainfrom
probonopd-patch-1
Closed

probonopd wants to merge 5 commits into
mainfrom
probonopd-patch-1

Conversation

@probonopd

@probonopd probonopd commented Aug 5, 2024 •

Copy link
Copy Markdown
Member

Try to trigger an appimagetool build in addition to uploading the continuous build to GitHub Releases.

Thus, when a change in this repository prevents the appimagetool AppImage from being built correctly, we will know immediately rather than a few months down the line.

This in part might have prevented

from having happened unnoticed.

Try to trigger an appimagetool build
@AppImage AppImage deleted a comment from github-actions Bot Aug 5, 2024
@AppImage AppImage deleted a comment from github-actions Bot Aug 5, 2024
@AppImage AppImage deleted a comment from github-actions Bot Aug 5, 2024
@AppImage AppImage deleted a comment from github-actions Bot Aug 5, 2024
@probonopd

Copy link
Copy Markdown
Member Author

TypeError: Cannot read properties of undefined (reading 'token')

How to do this correctly?

@TheAssassin

Copy link
Copy Markdown
Member

We've talked about this recently and I absolutely hate the idea. Plus, the token you try to use isn't even authorized to do so.

appimagetool automatically downloads the latest runtime anyway.

@TheAssassin TheAssassin closed this Aug 5, 2024
@TheAssassin

Copy link
Copy Markdown
Member

P.S.: If testing is your intention, you can clone appimagetool's repository here, too, and run the build script accordingly.

@TheAssassin
TheAssassin deleted the probonopd-patch-1 branch August 5, 2024 18:15
@probonopd

Copy link
Copy Markdown
Member Author

We've talked about this recently and I absolutely hate the idea.

Can you remind me of why you don't like this? Maybe combining the repos of type2-runtime and appimagetool would be a more elegant solution then?

appimagetool automatically downloads the latest runtime anyway.

Which is what I still think is too fragile, especially when the two are not in sync (which can happen due to developer error or simply because the user uses an older appimagetool version...)

@TheAssassin

Copy link
Copy Markdown
Member

Maybe combining the repos of type2-runtime and appimagetool would be a more elegant solution then?

Yet again, discussed and rejected. That's what we had, and it's what we never want to go back to.

@TheAssassin

Copy link
Copy Markdown
Member

You should open an issue by the way.

@probonopd

probonopd commented Aug 5, 2024 •

Copy link
Copy Markdown
Member Author

You should open an issue by the way.

Open an issue for what? Everything I propose doesn't seem to be liked by you (triggering builds in another repo automatically, merging repos). For bundling the runtime in the linuxdeployqt AppImage there is already an issue open,

@TheAssassin

Copy link
Copy Markdown
Member

The issue here is that this discussion is likely going to be lost in a closed PR.

Everything I propose doesn't seem to be liked by you

We've discussed every single option and I've always had the better arguments after all. It's tiring to reiterate over each of them every time some issue surfaces. It's nothing I'd do in a project because it's not productive.

It seems that the issue here is missing documentation from meetings we had...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants