Repository navigation
Redesign DMG installer background as a landscape drop-zone layout - #834
Conversation
The previous background was a 540x760 portrait with grey chevrons, so the mounted installer opened as a tall, oddly proportioned window. Replace it with a 700x424 landing-page-styled illustration: two neobrutalist cards for Cotabby and Applications, a blue arrow between them, and the sleeping tabby on the bottom edge. Finder window size, icon size, and icon centers in build_release_dmg.py are re-measured to match the cards in the new art.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe release DMG layout changes to a 700×504-point background, smaller icons and labels, horizontal app and Applications icon placement, and reduced grid spacing. The generated Finder window height includes an additional 28 points for the title bar. ChangesDMG Finder layout
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The DMG window geometry preserves the intended artwork area, and no concrete merge-blocking issue remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
95b817f to
c251bf8
Compare
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Redesigns the DMG installer with a 700×424 landscape drop-zone layout aligned to new artwork.
Changes:
- Updates Finder window, icon, label, spacing, and positioning settings.
- Aligns app and Applications icons with the illustrated drop zones.
| File | Description |
|---|---|
scripts/build_release_dmg.py |
Configures the new landscape DMG layout. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmgbuild's window_rect is Finder's full window frame, title bar included, so a rect matching the background's point size left the bottom 28pt of the illustration hidden until the window was resized.
Finder can show a tab bar and status/path bar regardless of the DS_Store view settings, which pushed the sleeping cat below the visible area. Pad the art with 80pt of continued paper texture and open the window at 504pt so the illustration stays fully visible with that chrome, and shows paper rather than Finder's default white without it.
…anchor Brings in FuJacob/cotabby through 7724926 (FuJacob#825, FuJacob#827, FuJacob#834, FuJacob#835, FuJacob#836, FuJacob#837, FuJacob#838): ghost text matched to the host's own rendering plus finishing the word being typed, Obsidian/Electron accessibility priming, rapid Tab accepts kept owned while the overlay presents, Apple Intelligence greyed out when unavailable, a new llama-recall eval fixture, the installer artwork and kickstart script, and a CI test-flakiness fix. Resolution, where both sides changed the same thing: - Suppression reasons: upstream's `CompletionContentPolicy` rejects any completion without a letter or digit (`noWordContent`), which subsumes this fork's `periodOnly`, so that case and its helper are removed and the bare-dot test now asserts the broader reason. Behaviour change worth knowing: a lone closing bracket or question mark is now withheld too, where this fork deliberately let those through; its test records that. - Prompt renderer: upstream's `personaLine(_:prefix:)` (the name only appears at a sign-off) wins; this fork's learned-phrases section is unchanged beside it. - Eval case schema: upstream added `visualContextSummary` and `clipboardContext` for its recall fixture; this fork's `screenText` and `learnedPhrases` stay alongside them. The harness prefers the pre-rendered summary and still puts raw `screenText` through the live local passes. Both scorer helpers kept. - Kept from this fork: the separate test host, the 2-4 word eval preset, phrase memory, the clock-time rule, the debug-artifact gate. Full suite: 2,724 tests, 16 skipped, 0 failures; the installed app's defaults byte-identical afterwards and no debug artifacts written. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Summary
scripts/build_release_dmg.pyso the Finder window size, icon size (72pt), label size, and the two icon centers line up with the cards in the new art.Preview
The app icon and Applications folder land inside the two cards:
(see attached mockup in the PR conversation)
Validation
dmgbuildagainst a Cotabby.app bundle, mounted it, and confirmedCotabby.appand theApplicationssymlink are present. Finder opened the previous iteration at the expected window size.assets/release/dmg_background.png,@2x) are unchanged, so.github/workflows/release.ymlandscripts/build_test_dmg.shneed no edits.Summary by CodeRabbit
The PR appears safe to merge based on the changes reviewed.
Summary
The PR replaces the portrait DMG background with a landscape drop-zone design and updates Finder window and icon settings. The latest changes add 80 points of background paper and increase the window height to accommodate it.
Reviews (2) · Last reviewed commit: "Open the DMG window taller with extra pa..."