Skip to content

Redesign DMG installer background as a landscape drop-zone layout - #834

Merged
FuJacob merged 3 commits into
mainfrom
feat/dmg-installer-background
Sep 28, 2026
Merged

FuJacob merged 3 commits into
mainfrom
feat/dmg-installer-background

Conversation

@FuJacob

@FuJacob FuJacob commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Replace the tall 540x760 DMG background (grey chevrons) with a 700x424 landscape illustration styled after the landing page: two neobrutalist drop-zone cards, a blue arrow, and the sleeping tabby on the bottom edge.
  • Update scripts/build_release_dmg.py so the Finder window size, icon size (72pt), label size, and the two icon centers line up with the cards in the new art.

Preview

The app icon and Applications folder land inside the two cards:

(see attached mockup in the PR conversation)

Validation

  • Built a test DMG locally with dmgbuild against a Cotabby.app bundle, mounted it, and confirmed Cotabby.app and the Applications symlink are present. Finder opened the previous iteration at the expected window size.
  • Release workflow paths (assets/release/dmg_background.png, @2x) are unchanged, so .github/workflows/release.yml and scripts/build_test_dmg.sh need no edits.

Summary by CodeRabbit

  • Other
    • Updated the release installer’s window layout, including its background, icon sizes and positions, label size, and spacing.

RetriggerConfidence Score: 5/5

The PR appears safe to merge based on the changes reviewed.

Summary

The PR replaces the portrait DMG background with a landscape drop-zone design and updates Finder window and icon settings. The latest changes add 80 points of background paper and increase the window height to accommodate it.

Reviews (2) · Last reviewed commit: "Open the DMG window taller with extra pa..."

Copilot AI lite review requested due to automatic review settings September 27, 2026 19:32
The previous background was a 540x760 portrait with grey chevrons, so the
mounted installer opened as a tall, oddly proportioned window. Replace it
with a 700x424 landing-page-styled illustration: two neobrutalist cards for
Cotabby and Applications, a blue arrow between them, and the sleeping tabby
on the bottom edge.

Finder window size, icon size, and icon centers in build_release_dmg.py are
re-measured to match the cards in the new art.
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cd186d25-f1fb-4f4d-9649-34828ed78c7b

📥 Commits

Reviewing files that changed from the base of the PR and between 8b1210d and 2bbedbf.

⛔ Files ignored due to path filters (2)
  • assets/release/dmg_background.png is excluded by !**/*.png
  • assets/release/dmg_background@2x.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • scripts/build_release_dmg.py

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The release DMG layout changes to a 700×504-point background, smaller icons and labels, horizontal app and Applications icon placement, and reduced grid spacing. The generated Finder window height includes an additional 28 points for the title bar.

Changes

DMG Finder layout

Layer / File(s) Summary
Update Finder layout settings
scripts/build_release_dmg.py
The script sets a 700×504-point background, updates icon size and placement, reduces label size and grid spacing, and adds 28 points to the configured window height for the title bar.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 2bbed

The DMG window geometry preserves the intended artwork area, and no concrete merge-blocking issue remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: replacing the DMG installer background with a landscape drop-zone layout and related positioning updates.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Redesigns the DMG installer with a 700×424 landscape drop-zone layout aligned to new artwork.

Changes:

  • Updates Finder window, icon, label, spacing, and positioning settings.
  • Aligns app and Applications icons with the illustrated drop zones.
File Description
scripts/​build_release_dmg.py Configures the new landscape DMG layout.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

dmgbuild's window_rect is Finder's full window frame, title bar included,
so a rect matching the background's point size left the bottom 28pt of the
illustration hidden until the window was resized.
Finder can show a tab bar and status/path bar regardless of the DS_Store
view settings, which pushed the sleeping cat below the visible area. Pad
the art with 80pt of continued paper texture and open the window at 504pt
so the illustration stays fully visible with that chrome, and shows paper
rather than Finder's default white without it.
@FuJacob
FuJacob merged commit 7cd5d6c into main Sep 28, 2026
6 checks passed
flexi767 added a commit to flexi767/cotabby that referenced this pull request Sep 30, 2026
…anchor

Brings in FuJacob/cotabby through 7724926 (FuJacob#825, FuJacob#827, FuJacob#834, FuJacob#835, FuJacob#836, FuJacob#837,
FuJacob#838): ghost text matched to the host's own rendering plus finishing the word
being typed, Obsidian/Electron accessibility priming, rapid Tab accepts kept
owned while the overlay presents, Apple Intelligence greyed out when
unavailable, a new llama-recall eval fixture, the installer artwork and
kickstart script, and a CI test-flakiness fix.

Resolution, where both sides changed the same thing:
- Suppression reasons: upstream's `CompletionContentPolicy` rejects any
  completion without a letter or digit (`noWordContent`), which subsumes this
  fork's `periodOnly`, so that case and its helper are removed and the bare-dot
  test now asserts the broader reason. Behaviour change worth knowing: a lone
  closing bracket or question mark is now withheld too, where this fork
  deliberately let those through; its test records that.
- Prompt renderer: upstream's `personaLine(_:prefix:)` (the name only appears at
  a sign-off) wins; this fork's learned-phrases section is unchanged beside it.
- Eval case schema: upstream added `visualContextSummary` and `clipboardContext`
  for its recall fixture; this fork's `screenText` and `learnedPhrases` stay
  alongside them. The harness prefers the pre-rendered summary and still puts
  raw `screenText` through the live local passes. Both scorer helpers kept.
- Kept from this fork: the separate test host, the 2-4 word eval preset, phrase
  memory, the clock-time rule, the debug-artifact gate.

Full suite: 2,724 tests, 16 skipped, 0 failures; the installed app's defaults
byte-identical afterwards and no debug artifacts written.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants