Skip to content

Fix flaky SymSpellCorrector background-load test on CI - #835

Merged
FuJacob merged 1 commit into
mainfrom
fix/symspell-test-timeout
Sep 28, 2026
Merged

FuJacob merged 1 commit into
mainfrom
fix/symspell-test-timeout

Conversation

@FuJacob

@FuJacob FuJacob commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

test_coldLookupsShareOneBackgroundLoadThenServeCorrections (added in #833) fails on GitHub's macOS runners, which is why main and every PR are red.

The test waits at most 5s for a 2-word French dictionary to load on the global utility queue. On the CI runner, other tests' full 82k-word English index builds occupy that queue for several seconds each; the CI log shows the French load publishing at 00:57:37.418, just after the 5s deadline. Locally those builds finish in well under a second, so it never reproduced.

Change

Raise the ceiling for the three background-load waits in SymSpellCorrectorTests to 60s. The waits return as soon as their condition holds, so passing runs are not slowed.

Validation

  • SymSpellCorrectorTests passes locally (12 tests).

RetriggerConfidence Score: 5/5

The PR appears safe to merge.

Summary

This PR raises three SymSpellCorrector background-load test waits from 5 seconds to a shared 60-second ceiling.

  • Passing waits still return as soon as their conditions are met.
  • No actionable regression was identified.

Reviews (1) · Last reviewed commit: "Give SymSpellCorrector test background l..."

Copilot AI lite review requested due to automatic review settings September 28, 2026 01:03
@FuJacob
FuJacob merged commit 420555e into main Sep 28, 2026
4 checks passed
@FuJacob
FuJacob deleted the fix/symspell-test-timeout branch September 28, 2026 01:03
@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 25cf1489-08f3-4391-a40b-7a4dcae1603f

📥 Commits

Reviewing files that changed from the base of the PR and between 8b1210d and 5d82bbe.

📒 Files selected for processing (1)
  • CotabbyTests/Services/Spelling/SymSpellCorrectorTests.swift
 ______________________________
< Blink twice if you're a bug. >
 ------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review effort: Lite
Findings: None

What changed in this PR

This pull request stabilizes SymSpellCorrector background-load tests on slower CI runners by increasing asynchronous wait limits.

Changes:

  • Adds a shared 60-second timeout.
  • Applies it to all three background-load waits.
  • Documents the CI queue contention rationale.
File Description
CotabbyTests/​Services/​Spelling/​SymSpellCorrectorTests.swift Extends asynchronous dictionary-load wait ceilings.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

flexi767 added a commit to flexi767/cotabby that referenced this pull request Sep 30, 2026
…anchor

Brings in FuJacob/cotabby through 7724926 (FuJacob#825, FuJacob#827, FuJacob#834, FuJacob#835, FuJacob#836, FuJacob#837,
FuJacob#838): ghost text matched to the host's own rendering plus finishing the word
being typed, Obsidian/Electron accessibility priming, rapid Tab accepts kept
owned while the overlay presents, Apple Intelligence greyed out when
unavailable, a new llama-recall eval fixture, the installer artwork and
kickstart script, and a CI test-flakiness fix.

Resolution, where both sides changed the same thing:
- Suppression reasons: upstream's `CompletionContentPolicy` rejects any
  completion without a letter or digit (`noWordContent`), which subsumes this
  fork's `periodOnly`, so that case and its helper are removed and the bare-dot
  test now asserts the broader reason. Behaviour change worth knowing: a lone
  closing bracket or question mark is now withheld too, where this fork
  deliberately let those through; its test records that.
- Prompt renderer: upstream's `personaLine(_:prefix:)` (the name only appears at
  a sign-off) wins; this fork's learned-phrases section is unchanged beside it.
- Eval case schema: upstream added `visualContextSummary` and `clipboardContext`
  for its recall fixture; this fork's `screenText` and `learnedPhrases` stay
  alongside them. The harness prefers the pre-rendered summary and still puts
  raw `screenText` through the live local passes. Both scorer helpers kept.
- Kept from this fork: the separate test host, the 2-4 word eval preset, phrase
  memory, the clock-time rule, the debug-artifact gate.

Full suite: 2,724 tests, 16 skipped, 0 failures; the installed app's defaults
byte-identical afterwards and no debug artifacts written.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants