feat(storybook): showcase all GoodWidget widgets with QA fixtures and theme overrides by goodbounties-nanoclaw-agent[bot] · Pull Request #253 · GoodDollar/GoodWidget

goodbounties-nanoclaw-agent · 2026-10-14T10:28:43Z

Closes #252

Summary

Adds the Showcase / Theme overrides / QA three-way story split to the remaining widgets per the plan in #252:

CitizenClaimWidget — Theme overrides + env control
GoodReserveWidget — split Showcase/QA + Theme overrides
GovernanceWidget — Onboarding moved to QA, env control dropped
AiCreditsWidget — MockBackend moved to QA + Theme overrides
SuperfluidCampaignWidget — API Contracts moved to QA + Theme overrides
GoodDataWidget — QA title renamed, Showcase + Theme overrides added

Each widget gets an MDX integrator doc, a deterministic QA fixture set backing its Playwright spec, and (where applicable) a Theme overrides playground scoped to the theme targets the widget actually renders.

Test plan

tsc --noEmit clean (only pre-existing baseline errors)
eslint clean
Full Playwright suite: 253 passed / 1 failed / 1 flaky / 1 skipped — the failure and flake are both AiCreditsWidget appkit connect wallet tests caused by VITE_REOWN_PROJECT_ID not being set in the CI/dev sandbox (pre-existing, unrelated to this change — confirmed zero diff on that spec file vs main)

Note on commit signing

Commits on this branch show as unsigned in this environment — a known, long-standing issue in this org (same symptom previously seen on #148, #179, and #227; root cause not yet pinned down). Per the pattern used on #227, please squash-merge this PR rather than rebase-merge — GitHub signs the resulting squash commit itself at merge time, independent of the source branch's signature state, which satisfies main's "require signed commits" ruleset.

🤖 Generated by goodbounties-nanoclaw-agent

…A fixtures and theme overrides Adds the Showcase/Theme-overrides/QA three-way story split to CitizenClaimWidget, GoodReserveWidget, GovernanceWidget, AiCreditsWidget, SuperfluidCampaignWidget, and GoodDataWidget per issue #252, including MDX integrator docs and deterministic QA fixtures backing each widget's Playwright states spec. Co-Authored-By: Claude <noreply@anthropic.com> On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)

Copilot

🟡 Changes recommended

Several showcased overrides are ineffective, environment switching can retain stale data, and new playgrounds lack required Playwright coverage.

9 open findings

Card background controls do not affect AiCreditsHero · New
Add Playwright smoke test for theme playground · New
Add Playwright smoke test for theme playground · New
Add Playwright smoke test for theme playground · New
Add Playwright smoke test for theme playground · New
Card controls do not theme ReserveSwapShell surfaces · New
Environment changes do not refresh claim data · New
Add Playwright smoke test for theme playground · New
Card background overrides do not affect widget shell · New

What changed in this PR

Adds consistent Showcase, Theme Overrides, QA, and integrator documentation across the remaining widgets.

Changes:

Adds theme playgrounds and widget guides.
Reorganizes deterministic QA stories and updates Playwright story IDs.
Adds environment and live-connector showcase controls.

File	Description
`tests/widgets/superfluid-campaign-widget/states.spec.ts`	Updates QA story IDs.
`tests/widgets/governance-widget/onboarding.spec.ts`	Updates onboarding story IDs.
`tests/widgets/goodreserve-widget/states.spec.ts`	Updates Showcase and QA story IDs.
`tests/widgets/gooddata-widget/states.spec.ts`	Updates QA story IDs.
`examples/storybook/src/stories/superfluid-campaign-widget/SuperfluidCampaignWidgetThemeOverrides.stories.tsx`	Adds theme playground.
`examples/storybook/src/stories/superfluid-campaign-widget/SuperfluidCampaignWidgetApiContracts.stories.tsx`	Moves API contracts under QA.
`examples/storybook/src/stories/superfluid-campaign-widget/SuperfluidCampaignWidget.mdx`	Documents theme overrides.
`examples/storybook/src/stories/helpers/goodDataWidgetStories.tsx`	Registers and exposes the live connector.
`examples/storybook/src/stories/helpers/citizenClaimWidgetStories.tsx`	Adds environment and initial-tab inputs.
`examples/storybook/src/stories/governance-widget/GovernanceWidget.mdx`	Documents environment availability.
`examples/storybook/src/stories/governance-widget/GovernanceOnboarding.stories.tsx`	Moves onboarding stories under QA.
`examples/storybook/src/stories/goodreserve-widget/GoodReserveWidgetThemeOverrides.stories.tsx`	Adds theme playground.
`examples/storybook/src/stories/goodreserve-widget/GoodReserveWidgetShowcase.stories.tsx`	Retains live showcase stories.
`examples/storybook/src/stories/goodreserve-widget/GoodReserveWidgetQA.stories.tsx`	Adds deterministic reserve fixtures.
`examples/storybook/src/stories/goodreserve-widget/GoodReserveWidget.mdx`	Adds integrator documentation.
`examples/storybook/src/stories/gooddata-widget/GoodDataWidgetThemeOverrides.stories.tsx`	Adds theme playground.
`examples/storybook/src/stories/gooddata-widget/GoodDataWidgetShowcase.stories.tsx`	Adds live-connector showcase.
`examples/storybook/src/stories/gooddata-widget/GoodDataWidgetQA.stories.tsx`	Renames the QA namespace.
`examples/storybook/src/stories/gooddata-widget/GoodDataWidget.mdx`	Adds integrator documentation.
`examples/storybook/src/stories/citizen-claim-widget/CitizenClaimWidgetThemeOverrides.stories.tsx`	Adds theme playground.
`examples/storybook/src/stories/citizen-claim-widget/CitizenClaimWidgetShowcase.stories.tsx`	Adds environment controls.
`examples/storybook/src/stories/citizen-claim-widget/CitizenClaimWidget.mdx`	Documents controls and theming.
`examples/storybook/src/stories/ai-credits-widget/AiCreditsWidgetThemeOverrides.stories.tsx`	Adds theme playground.
`examples/storybook/src/stories/ai-credits-widget/AiCreditsWidgetShowcase.stories.tsx`	Removes the mock fixture from Showcase.
`examples/storybook/src/stories/ai-credits-widget/AiCreditsWidgetQA.stories.tsx`	Moves the mock fixture into QA.
`examples/storybook/src/stories/ai-credits-widget/AiCreditsWidget.mdx`	Updates showcase and QA guidance.

🧠 Review effort: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

+      dark_Card: {
+        background: args.darkCardBackground,
+        borderColor: args.darkCardBorderColor,
+      },
+      light_Card: {
+        background: args.lightCardBackground,
+        borderColor: args.lightCardBorderColor,
+      },


+export default meta
+type Story = StoryObj<OverridesArgs>
+
+export const Playground: Story = {


+export default meta
+type Story = StoryObj<OverridesArgs>
+
+export const Playground: Story = {


+export default meta
+type Story = StoryObj<OverridesArgs>
+
+export const Playground: Story = {


+export default meta
+type Story = StoryObj<OverridesArgs>
+
+export const Playground: Story = {


+            <GoodReserveWidget
+              provider={provider}
+              mockState={reserveWidgetMockStates.idleBuy}
+              defaultTheme="dark"
+              themeOverrides={themeOverrides}


    <CitizenClaimWidget
      provider={provider}
-      environment="development"
+      environment={environment}


+export default meta
+type Story = StoryObj<OverridesArgs>
+
+export const Playground: Story = {


+            <li>
+              <strong>dark_Card / light_Card</strong>: outer widget shell, ActionCard, the
+              LeaderboardSummary card, and each LeaderboardRow all cascade from this theme —
+              demonstrated below on the outer shell and ActionCard.
+            </li>


goodbounties-nanoclaw-agent · 2026-10-21T12:21:48Z

Merge order note (per Olivia, Bounty Lead, 2026-10-21): hold this PR until #227 (Thales's AI Credits dashboard fixes) lands first — both touch GoodDataWidgetQA.stories.tsx, goodDataWidgetStories.tsx, and tests/widgets/gooddata-widget/states.spec.ts. Merging #227 first avoids a rebase/conflict on this branch. Please don't merge #253 ahead of #227.

Abuchtela · 2026-10-29T14:08:26Z

@Abuchtela is interested in taking the GoodBounty follow-up for #253 (theme-control fixes, CitizenClaim environment remount, shared environment options, and QA evidence). Proposed ETA: November 2, 2026, subject to fork/write access and local test execution. Please confirm whether the bounty can be claimed here or requires a separate claim flow.

L03TJ3 · 2026-10-29T16:33:22Z

@Abuchtela assignments for issues happens in the issues, not in the pull-requests.
its also already assigned: #264

goodbounties-nanoclaw-agent Bot requested review from a team and L03TJ3 and a balanced review from Copilot October 14, 2026 10:28

goodbounties-nanoclaw-agent Bot temporarily deployed to internal October 14, 2026 10:28 Inactive

goodbounties-nanoclaw-agent Bot deployed to preview-storybook October 14, 2026 10:28

View deployment

goodbounties-nanoclaw-agent Bot mentioned this pull request Oct 14, 2026

[BountyPrep] Storybook: missing primitives and design system gaps #254

Open

Copilot started reviewing October 14, 2026 10:32

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

This was referenced Oct 21, 2026

[PLAN] Widget showcase in storybook #252

Open

[GoodBounty] Finalize Widget showcase in Storybook PR (#253) #264

Open

This was referenced Oct 31, 2026

fix(storybook): finalize widget showcase for #253 (closes #264) #272

Open

[GoodBounty] Finalize Next Task component PR (#248) #276

Open

cyzcz mentioned this pull request Nov 7, 2026

fix(storybook): finalize widget showcase theme controls, environment remount, and deterministic RPC tests (#264) #292

Open

Navigation Menu

Repository navigation

feat(storybook): showcase all GoodWidget widgets with QA fixtures and theme overrides - #253

feat(storybook): showcase all GoodWidget widgets with QA fixtures and theme overrides#253
goodbounties-nanoclaw-agent[bot] wants to merge 1 commit into
mainfrom
feat/gw250-storybook-showcase

goodbounties-nanoclaw-agent Bot commented Oct 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

goodbounties-nanoclaw-agent Bot commented Oct 21, 2026

Uh oh!

Abuchtela commented Oct 29, 2026

Uh oh!

L03TJ3 commented Oct 29, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

goodbounties-nanoclaw-agent Bot commented Oct 14, 2026

Summary

Test plan

Note on commit signing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

goodbounties-nanoclaw-agent Bot commented Oct 21, 2026

Uh oh!

Abuchtela commented Oct 29, 2026

Uh oh!

L03TJ3 commented Oct 29, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants