Repository navigation
fix(storybook): finalize widget showcase theme controls, environment remount, and deterministic RPC tests (#264) - #292
Open
cyzcz wants to merge 10 commits into
Conversation
…n Theme overrides
…hes with mock provider
…d add theme screenshots
…nd capture full-page screenshots
…rministic mocked RPC responses in showcase.spec.ts (GoodDollar#264) Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finalizes PR #253 (
feat/gw250-storybook-showcase) for #264, including all fixes from #272 plus deterministic mocked-RPC verification for theCitizenClaimWidgetenvironment switch.Closes #264
Changes
dark_Card.background/light_Card.backgroundcontrols onAiCreditsWidget,GoodReserveWidget, andSuperfluidCampaignWidgetplaygrounds to separate, readabledarkandlightbase theme surface tokens (backgroundSurface,backgroundInput,backgroundDark), and documented the token cascade andbackgroundSurfaceAltbadge limitation inDocsCalloutand MDX docs.CitizenClaimWidgetEnvironment Switching:key={environment}to<CitizenClaimWidget>insideCitizenClaimWidgetStoryShellso switchingenvironmentin Storybook remounts the widget and refreshes contract reads.ENVIRONMENT_OPTIONSHelper:ENVIRONMENT_OPTIONSintoexamples/storybook/src/stories/helpers/environmentOptions.ts.tests/widgets/citizen-claim-widget/showcase.spec.ts):0x329377cbeeF39f01b0Ea04B80465c9eB47D3ED12, 20 bytes / 40 hex chars).eth_callrequests with distinct ABI-encoded entitlements fordevelopment(10 G$from0x6b86...7c5f) vs.production(42 G$from0x43d7...ea4a1), asserting both DOM remount and that the rendered entitlement updates from10to42upon switchingenvironmentin-place.fullPage: trueto all Theme Overrides and Showcase Playwright screenshot captures.