Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:integration |
✅ Succeeded | 1m 39s | View ↗ |
nx run ghost:test:bullmq:scenarios |
✅ Succeeded | 45s | View ↗ |
nx run ghost:test:bullmq |
✅ Succeeded | 33s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 3m | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 1m 46s | View ↗ |
nx run ghost:test:ci:integration |
✅ Succeeded | 1s | View ↗ |
nx run ghost:test:ci:e2e |
✅ Succeeded | 2s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 18s | View ↗ |
Additional runs (11) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-11-04 11:54:17 UTC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/dya-38-custom-fields-ga #32549 +/- ##
================================================================
Coverage ? 85.83%
================================================================
Files ? 1414
Lines ? 53618
Branches ? 9238
================================================================
Hits ? 46024
Misses ? 6407
Partials ? 1187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e4cd2fa to
9a641e6
Compare
ref https://linear.app/ghost/issue/DYA-212/remove-the-custom-fields-labs-flag Custom fields are released on every site, so nothing reads their Labs flag any more: the server no longer refuses field changes without it, Admin always offers custom fields in Settings, Settings search, the import's column mapping and member activity, and Portal always asks for the fields open to a signed-in member and heads their account row "Account". The host limit is now the only thing that switches custom fields off. Portal stays on its current version line, since it needs nothing from Ghost that the versions on that line lack: each of them can answer Portal's request for a member's fields, and Portal reads a site that can't as having none. On a version that never released custom fields, members see no fields and the "Account" heading. The tests for a server without custom fields go with the flag.
820b51b to
231defe
Compare
9a641e6 to
0f53873
Compare

ref https://linear.app/ghost/issue/DYA-212/remove-the-custom-fields-labs-flag
Stacked on #32539, which releases custom fields. Kept in draft until that has merged and reached every server Admin talks to, and nothing needs the flag to switch custom fields off.
What it does
Removes the
membersCustomFieldsLabs flag. Once #32539 releases custom fields on every site, nothing needs the flag, so this deletes every read of it along with the code paths and tests for a server without custom fields.// ghost/core/shared/labs.js const GA_FEATURES = [ // ... 'stripeCheckoutDesign', - 'membersCustomFields', ];The custom fields host limit is now the only thing that switches custom fields off, and it is unchanged.
Decisions
Portal stays on its current version line. Every Ghost version loads Portal's newest patch on the minor line it pins, so Portal moves to a new minor line only when it needs something from Ghost that versions on the current line don't have, as when it needed Ghost to serve the gift card textures (#31651) or to accept gift delivery choices (#29968). Without the flag, Portal needs nothing new. Every Ghost version on the current line can answer Portal's request for a member's custom fields, and Portal reads a site that can't as having no fields. So this ships as a Portal patch, live on every site on that line once it merges. On a Ghost version that never released custom fields, members see no fields, as before, and their account row reads "Account" rather than their name.
No new tests. A site running this branch behaves as it does with the flag released. The custom fields tests now run with the flag nowhere, which shows nothing reads it: the Admin fixtures, Portal's tests and the server's tests no longer set it, and Portal's updated tests fail against the Portal source before this change. The tests for a server without custom fields go, since that state no longer exists.
Suggested follow-ups
Validation
On a site running this branch:
Once the Portal patch is live, on a site running a Ghost version from before this change: Portal's account page works, shows no custom fields on a version that never released them, and the account row reads "Account".