Repository navigation
Conversation
Co-authored-by: Zhiwei(Jeffrey) Hu <huzhiwei@outlook.com>
Co-authored-by: Zhiwei(Jeffrey) Hu <huzhiwei@outlook.com>
Co-authored-by: Zhiwei(Jeffrey) Hu <huzhiwei@outlook.com>
Co-authored-by: Zhiwei(Jeffrey) Hu <huzhiwei@outlook.com>
Co-authored-by: Zhiwei(Jeffrey) Hu <huzhiwei@outlook.com>
The site has eight translated languages but only one feed, and the auto-discovery <link> emitted for every page pointed at the English feed. Readers of /ja/, /zh/, etc. who used their reader's "subscribe" button therefore got English content (issues bitcoinops#285 and bitcoinops#251). Move the Atom body into _includes/functions/atom-feed.xml, parameterized by language, feed path and home path. feed.xml becomes a thin wrapper, and each translated language gets /<lang>/feed.xml. The <link> in head.html and the "subscribe via RSS" line in the blog, newsletters and publications layouts now point at the feed for the page's own language. Verified: eight feeds are generated (zh/ja/de/fr/cs/hi: 10 entries each, es: 2, pt: 1); every entry in a language feed links to a page under that language; the English feed is unchanged apart from the addition of xml:lang="en" and hreflang="en"; htmlproofer passes on 28,168 internal links.
murchandamus
reviewed
Nov 4, 2026
murchandamus
left a comment
murchandamus
left a comment
Collaborator
There was a problem hiding this comment.
Concept ACK, I think. Have to take a better look at this still.
The 196 commits are a bit distracting, it’s really just one commit on the end that should be rebased on the latest state of the repository.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site has eight translated languages but one feed, and the auto-discovery link emitted for every page pointed at the English one, so subscribing from /ja/blog/ or /zh/newsletters/ gave English content.
Changes:
_includes/functions/atom-feed.xml: the Atom body, parameterized by language, feed path, home path and entry limit.feed.xml: thin wrapper around it. English output is unchanged apart fromxml:lang="en"andhreflang="en"._includes/head.html: the discovery link now points at the feed forpage.lang(replaces{% feed_meta %}, which cannot vary per page)._includes/functions/rss-subscribe.mdplus the blog/newsletters/publications layouts: the subscribe line is no longer English-only.Testing (clean build):
Closes #285. Refs #251 — the language-selector graphics item there is still open.