Repository navigation
Conversation
…rdly, which skipped the main object in the image sometimes
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 37.28% 35.47% -1.82%
==========================================
Files 9 9
Lines 649 733 +84
Branches 127 153 +26
==========================================
+ Hits 242 260 +18
- Misses 403 469 +66
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| ][property_name] | ||
| self.info[issue_type] = imagelab_info.get(issue_type, {}) | ||
|
|
||
| # todo: revisit when there are more issues using same properties like light and dark |
There was a problem hiding this comment.
Is the intention to map compatible issues to each other based on the shared property?
Suppose an issue (e.g. LIGHT) is valid (exists in self.issue_types) but is not set in self.info. Do we assume its counterpart (e.g. DARK) has been set with the desired property?
There was a problem hiding this comment.
Yes. In imagelab.find_issues I get a defer set of issues to re-use computations. This defer set will add, all but one of the compatible issues to the defer set. These left out issues will be populated using the one that was left out of defer set.
jwmueller
left a comment
There was a problem hiding this comment.
messaged you all my comments for easier discussion, but I think they can be addressed in future PRs (or this one if you can get to them in time and then re-request my review)
Co-authored-by: Elías Snorrason <eliassno@gmail.com>
Co-authored-by: Elías Snorrason <eliassno@gmail.com>
Bug fixes:
imagelab.report()imagelab.visualize()Improvements:
imagelab.visualize(issue_types)phashRefactoring
ImageProperty.calculatereturns dict instead of a single valuescore_columnproperty in ImageProperty for specifying which series to use for evaluating scores📚 Documentation preview 📚: https://cleanvision--105.org.readthedocs.build/en/105/