Repository navigation
Conversation
ktz03
marked this pull request as ready for review
October 20, 2026 01:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exact_duplicateshashes flattened pixel bytes, so a 3×2 image and a 2×3 image containing the same byte sequence are incorrectly grouped as exact duplicates. Include the pixel-array shape in the MD5 input so dimensions and channel layout participate in the comparison.Impact
Only the MD5 input used for exact-duplicate detection changes. Genuine decoded-pixel duplicates, including copies saved as PNG and TIFF, remain grouped. The five perceptual hash algorithms are unchanged.
Testing
pytest --verbose --cov=src/cleanvision/ --cov-config .coveragerc tests/: 92 passed, compared with 86 passed, 6 failed on the original production code using the same test cases. This includes the existing Hugging Face, Torchvision and anonymous S3 checks.src tests, and strict mypy over all 18 source files pass.Unaddressed cases: local execution was Windows CPU/Python 3.12.14, NumPy 1.26.4 and Pillow 13.0.0. Other platform/Python combinations were not run locally.
References
This retains the decoded-pixel hashing approach introduced in #105, rather than comparing encoded image-file bytes.
Reviewer Notes
Internal MD5 strings change; the current implementation retains duplicate sets rather than exposing per-image hashes. No precomputed-hash API is introduced.
Read the Docs currently fails in the unchanged Hugging Face tutorial while resolving the legacy
cats_vs_dogsdataset ID, before duplicate detection runs (build log).