Repository navigation
Read Lady as a given name under a Spanish choice; keep #913's last eight titles - #1055
Merged
Merged
Conversation
…ght titles (#913) The nine words #913 held after baron were measured with the fielded corpora read by their filed boxes. Eight lose where their filers state the reading (sir: 287 title boxes against 17 forenames), and stay titles, their counts recorded on their title readings. Lady splits by country: a British title (160 title boxes, 59 UK donors) and a given name for 137 ORCID researchers, 111 in Spanish-speaking countries, so es.toml gives it a given reading a Spanish choice turns on, as zh.toml's hon is under a Chinese one; locales.ES makes that choice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the Lady choice test the first commit's body named but never wrote; attach lady to chief, mayor, provost and captain, so Lady Chief Justice and the offices keep the title under a Spanish choice; record the choice's costs (the peeress's given name joining the family under locales.ES, the comma reversal, a leading The, a conjoined pair); state the move totals' provenance (the fourteen-word spike) and count sir and bishop by every name holding them; make the recipe's unit and comparator explicit; fold Lady into the new ES pack's release bullet; widen H9's language-choice bullet to a title borne as a whole given name; retire the Open: #913 lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Correct the title-or-name claim (the family-comma site reports nothing), the choice's count (556: Lady Captain keeps the title with the new partner), bishop's count alone (43, the spike's 44 holding one name sir moved), and carry the peeress's cost into the merged ES release bullet; record that a title after Lady other than the five loses the phrase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/design/decisions/H9-title-phrase.md # tests/v2/rules_budget.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settles the last nine words #913 held. The default parse changes for none of them. A Spanish choice of languages, and so
locales.ES, now readsLadyas a given name.How they were measured
All nine were given a
givenreading in a throwaway tree and measured against master. Following the lesson of #1054, the fielded corpora were read by the boxes their filers typed the word into (local_agreement.py --list), not by reading the names.Eight stay titles
Most of their filers typed the word in the title box, and most other moves are real titles:
Admiral Sir Ben Key)GORDON, BISHOP SIMON)Canon PowerShot)Lieutenant General Ian Cave)Each word's counts are recorded in the note on its title reading in
en.toml, followingjudge's note.Lady: a title by default, a given name under Spanish
Lady Annabel Goldsmith).es.tomlgives it agivenreading writtendefault = false, which a Spanish choice turns on, the same wayzh.toml'shonworks under a Chinese choice.locales.ESmakes that choice, so the pack readsLady Heidenreichas given 'Lady'. The title is then one only inside a phrase.Hon Lady Smith,Lady of Shalottand the officesladynow attaches to by name keep it:Lady Justice,Lady Chief Justice,Lady Mayor,Lady ProvostandLady Captain.The costs matter only to someone parsing British names under a Spanish choice. A peeress written with the bare title reads given 'Lady', and under
locales.ESher own given name joins the family (Lady Annabel Goldsmith→ family 'Annabel Goldsmith').John Smith, Ladyreverses, as Hon does. A title afterLadyother than the five loses the phrase too (Lady Judge Smith→ given 'Lady'). All of these are recorded in decisions/H9.Under the choice, 556 local-corpus texts move against master. The default parse moves nothing. Every local-corpus text holding
ladyor one of the four office words reads as it does on master, ambiguity reports included, and the committed snapshot gains only the new rules example.Changes
nameparser/vocab/en.tomlgets notes on the nine words;nameparser/vocab/es.tomlgetslady's given reading.Open: #913lines in decisions/H1, decisions/vocabulary-collisions and decisions/vocabulary-model are removed, and the RFC's two mentions are dated.Lady Heidenreichexample with and without[es]. H9's Accepted bullets grew from 545 to 590 words in all, this one from 115 to 160, sotests/v2/rules_budget.jsonis re-recorded. The new clause reads the signal the bullet already reads, the language choice.docs/locales.rstadds Lady to theesrow and a doctest after Hon's.docs/release_log.rstfolds Lady into the new ES pack's bullet, since no released version had the pack.test_a_spanish_choice_reads_lady_as_a_given_namecovers the plain choice andlocales.ES: the given name, the seven phrases that keep the title, and the costs.tests/v2/test_locales.py, the ES pack's list of words its choice changes gainslady, and its witness names gainLady Heidenreich.The suite, the serial benchmark tests, ruff, mypy and the Sphinx doctests pass locally.
Closes #913.
🤖 Generated with Claude Code