Skip to content

Docs MCP tool failures omit isError #1600

Closed

Description

@betegon

Docs MCP catches tool execution failures and returns JSON error text without isError: true. MCP clients therefore receive a successful tool result containing an error message.

For example, calling get-available-features without OPENROUTER_API_KEY returns an error envelope without the standard error flag. Exceptions from search-docs follow the same path. The SDK returns these caught results unchanged.

The shared errorEnvelope helper should include isError: true. This behavior is inherited from the original Worker.

Acceptance criteria:

  • Results returned through errorEnvelope include isError: true and retain their error text.
  • Protocol-level tests cover a missing API key and a search-docs execution failure without calling a model.
  • Successful tool results and the separate /internal/docs HTTP contract remain unchanged.

Separate follow-up to the Docs MCP port (#1597). Keep this behavioral fix outside the migration PR.

Activity

  1. added
    bugSomething isn't working
    MCPSentry MCP tools, transports, and documentation
    on Oct 22, 2026
  2. linear-code commented on Oct 22, 2026

    @linear-code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    MCPSentry MCP tools, transports, and documentationbugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions