Skip to content

fix(docs-mcp): mark tool failures as errors - #1653

Open
thomasjiangcy wants to merge 2 commits into
getsentry:mainfrom
thomasjiangcy:fix/docs-mcp-error-results
Open

thomasjiangcy wants to merge 2 commits into
getsentry:mainfrom
thomasjiangcy:fix/docs-mcp-error-results

Conversation

@thomasjiangcy

Copy link
Copy Markdown

Summary

Fixes #1600 by marking caught Docs MCP tool failures with the standard isError: true flag while preserving their existing error content.

Changes

  • Mark results returned by the shared errorEnvelope helper as MCP errors.
  • Add protocol-level regression coverage for a missing OpenRouter API key and search-docs execution failures.
  • Leave successful tool results and the separate /internal/docs HTTP contract unchanged.

thomasjiangcy and others added 2 commits October 24, 2026 17:33
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex CLI Agent <noreply@openai.com>
@vercel

vercel Bot commented Oct 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
sentry-local Skipped Skipped Oct 24, 2026 9:48am UTC

Request Review

@github-actions github-actions Bot added the risk: medium PR risk score: medium label Oct 24, 2026

This branch was previously deployed

1 inactive deployment
Preview — 6ba1f53c Deployed Oct 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs MCP tool failures omit isError

1 participant