Repository navigation
runsc/boot: validate version before loading async pages during restore - #14279
Open
DARSHANR007 wants to merge 1 commit into
Open
DARSHANR007 wants to merge 1 commit into
DARSHANR007 wants to merge 1 commit into
Conversation
nybidari
reviewed
Sep 11, 2026
nybidari
requested changes
Sep 11, 2026
DARSHANR007
force-pushed
the
fix-restore-version-check
branch
from
September 20, 2026 04:39
1968604 to
5f24412
Compare
shailend-g
removed their request for review
September 30, 2026 21:42
Collaborator
|
is the PR still alive? |
DARSHANR007
force-pushed
the
fix-restore-version-check
branch
from
October 17, 2026 05:25
5f24412 to
ddf6027
Compare
Contributor
Author
Yes , the PR is active. I have rebased onto the latest master to resolve merge conflicts. The requested nil check on restoreDone was addressed in onRestoreFailed. @nybidari @milantracy could you please take another look and approve CI? |
nybidari
approved these changes
Oct 23, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 24, 2026
### Problem In `runsc/boot/controller.go`, `Restore()` spawned `kernel.NewAsyncMFLoader` before checking the checkpoint version. When restoring a checkpoint from a different `runsc` build, the background loader started parsing incompatible page headers immediately, causing a panic (`makeslice: len out of range`) instead of returning a clean error. ### My fix Move statefile reading and the version check before creating `mainMF` and starting `NewAsyncMFLoader`. Incompatible checkpoints now fail fast with a clear version error. Fixes #14278 FUTURE_COPYBARA_INTEGRATE_REVIEW=#14279 from DARSHANR007:fix-restore-version-check ddf6027 PiperOrigin-RevId: 1005912581
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 24, 2026
### Problem In `runsc/boot/controller.go`, `Restore()` spawned `kernel.NewAsyncMFLoader` before checking the checkpoint version. When restoring a checkpoint from a different `runsc` build, the background loader started parsing incompatible page headers immediately, causing a panic (`makeslice: len out of range`) instead of returning a clean error. ### My fix Move statefile reading and the version check before creating `mainMF` and starting `NewAsyncMFLoader`. Incompatible checkpoints now fail fast with a clear version error. Fixes #14278 FUTURE_COPYBARA_INTEGRATE_REVIEW=#14279 from DARSHANR007:fix-restore-version-check ddf6027 PiperOrigin-RevId: 1005912581
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 24, 2026
### Problem In `runsc/boot/controller.go`, `Restore()` spawned `kernel.NewAsyncMFLoader` before checking the checkpoint version. When restoring a checkpoint from a different `runsc` build, the background loader started parsing incompatible page headers immediately, causing a panic (`makeslice: len out of range`) instead of returning a clean error. ### My fix Move statefile reading and the version check before creating `mainMF` and starting `NewAsyncMFLoader`. Incompatible checkpoints now fail fast with a clear version error. Fixes #14278 FUTURE_COPYBARA_INTEGRATE_REVIEW=#14279 from DARSHANR007:fix-restore-version-check ddf6027 PiperOrigin-RevId: 1005912581
Collaborator
|
[🤖] Needs rebase. |
Contributor
Author
|
@milantracy Please can you review the PR here. Thanks |
Collaborator
|
there are some failures at https://buildkite.com/gvisor/pipeline/builds/52153 for the PR. |
Move statefile reading and version check before spawning AsyncMFLoader so incompatible checkpoints fail fast with a version error instead of panicking. Fixes google#14278
DARSHANR007
force-pushed
the
fix-restore-version-check
branch
from
October 30, 2026 08:24
7d41129 to
e42a6d2
Compare
Contributor
Author
@milantracy I accidently created a merge commit while syncing with upstream , which caused the buildkite failures . Ive rebased it . Please have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
runsc/boot/controller.go,Restore()spawnedkernel.NewAsyncMFLoaderbefore checking the checkpoint version. When restoring a checkpoint from a differentrunscbuild, the background loader started parsing incompatible page headers immediately, causing a panic (makeslice: len out of range) instead of returning a clean error.My fix
Move statefile reading and the version check before creating
mainMFand startingNewAsyncMFLoader. Incompatible checkpoints now fail fast with a clear version error.Fixes #14278