Repository navigation
runsc/boot: validate version before loading async pages during restore - #16298
Closed
copybara-service[bot] wants to merge 1 commit into
Closed
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl1005912581
branch
2 times, most recently
from
October 24, 2026 09:36
572f6ff to
1e1821a
Compare
### Problem In `runsc/boot/controller.go`, `Restore()` spawned `kernel.NewAsyncMFLoader` before checking the checkpoint version. When restoring a checkpoint from a different `runsc` build, the background loader started parsing incompatible page headers immediately, causing a panic (`makeslice: len out of range`) instead of returning a clean error. ### My fix Move statefile reading and the version check before creating `mainMF` and starting `NewAsyncMFLoader`. Incompatible checkpoints now fail fast with a clear version error. Fixes #14278 FUTURE_COPYBARA_INTEGRATE_REVIEW=#14279 from DARSHANR007:fix-restore-version-check ddf6027 PiperOrigin-RevId: 1005912581
copybara-service
Bot
force-pushed
the
test/cl1005912581
branch
from
October 24, 2026 10:20
1e1821a to
f04db82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runsc/boot: validate version before loading async pages during restore
Problem
In
runsc/boot/controller.go,Restore()spawnedkernel.NewAsyncMFLoaderbefore checking the checkpoint version. When restoring a checkpoint from a differentrunscbuild, the background loader started parsing incompatible page headers immediately, causing a panic (makeslice: len out of range) instead of returning a clean error.My fix
Move statefile reading and the version check before creating
mainMFand startingNewAsyncMFLoader. Incompatible checkpoints now fail fast with a clear version error.Fixes #14278
FUTURE_COPYBARA_INTEGRATE_REVIEW=#14279 from DARSHANR007:fix-restore-version-check ddf6027