Repository navigation
feat(studio): toggle the shortcuts panel with the question-mark key - #6042
Draft
xiajiahang wants to merge 1 commit into
Draft
xiajiahang wants to merge 1 commit into
xiajiahang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Press
?to toggle Studio's existing keyboard shortcuts panel, including while the preview iframe has focus. Escape keeps closing it, and the default shortcut list includes?.Why
Keyboard help currently requires clicking the timeline toolbar button. Typing a question mark in a text field should continue to enter text.
Related work
Refs #5580. B-Payal expressed interest in this issue on October 14. No corresponding PR was found when rechecked before opening. This PR is a draft so the maintainer and original claimant can coordinate ownership before it proceeds.
How
?through the existing preview iframe keyboard bridge, preserving editable-target checks and listener cleanup on reload and unmount.Before
Pressing
?leaves the panel closed. Capture from an isolated browser page mounting the actual Studio component.After
The same key opens the panel. The browser verification page also mounts the actual preview hotkey bridge; typing
?in either document's input remains text. These are component verification captures, not a full-project Studio end-to-end test.Test plan
a8b576d15.0160fbee2base: 7,946 passed, 16 todo; 698 files passed, 1 skipped (--maxWorkers=2). The subsequent upstream changes are a release bump and an engine fix; neither changes these Studio files.The commit is authored by
xiajiahangand verified with GitHub's signature.