Repository navigation
fix(studio): moving clips that sit in wrapper divs no longer times the wrappers - #6046
Open
miguel-heygen wants to merge 2 commits into
Open
miguel-heygen wants to merge 2 commits into
miguel-heygen wants to merge 2 commits into
Conversation
…e wrappers Opening a new track renumbered every row of the file, including wrapper divs the preview runtime timed only so the timeline could show them. Those rows now stay out of the renumber unless the user moved them, so the file never gains data-start/data-track-index on an untimed wrapper.
Contributor
Edit accuracy: accurate 271 (base branch 271), smooth 127 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (1)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Opening a new track while moving clips in Studio no longer writes
data-start/data-track-indexonto untimed wrapper elements around those clips.Why
Inside Studio, the preview runtime gives an id'd or animated untimed element a timing so the timeline can show it as a row. Opening a new track (dropping in the gap above or below the rows) renumbered every row of the file, so those wrappers were saved with
data-start="0"and a track. The project then failedhyperframes checkwithvideo_nested_in_timed_element, which means a render with wrong frames. A drop onto an existing row writes only the dragged clip and was never affected. The same renumber also serves the z-order menu's "new track" move and asset drops into a new track, and the asset drop could fail outright next to such a wrapper.Related work
The runtime marks the elements it times for discovery with
data-hf-autostamped; its tests pin that stamping, so the runtime is unchanged. Editing such a row directly still makes its timing part of the file, as before.How
Rows are tagged
runtimeStampedwhere they are created from the manifest. The shared new-track layout (layoutAfterTrackInsert, used by all three paths) leaves those rows out of the renumber unless they are the dragged clip or part of the selection.Test plan
hyperframes check; before the fix it failed with threevideo_nested_in_timed_elementerrors. I did not drive a real browser.Before
main: one clip dragged to a new track, with three wrapper divs around clips. The savedindex.htmlgainsdata-start="0"and a track on every wrapper, andhyperframes checkfails with threevideo_nested_in_timed_elementerrors. This is the saved file and thecheckoutput, not a Studio screen: the browser harness available here shows no timeline rows.After
This branch, the same move: only the dragged video's track changes, the wrappers are untouched, and
hyperframes checkpasses (0 errors, 0 warnings).