Repository navigation
Reenable binskim for tsp.exe as node issue was resolved - #12508
Open
Timothee Guerin (timotheeguerin) wants to merge 3 commits into
Open
Timothee Guerin (timotheeguerin) wants to merge 3 commits into
Timothee Guerin (timotheeguerin) wants to merge 3 commits into
Conversation
Contributor
|
No changes needing a change description found. |
Timothee Guerin (timotheeguerin)
marked this pull request as ready for review
November 9, 2026 13:55
Timothee Guerin (timotheeguerin)
requested review from
catalinaperalta,
iscai-msft,
Laurent Mazuel (lmazuel) and
Mark Cowlishaw (markcowl)
as code owners
November 9, 2026 13:55
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The standalone CLI publishing pipeline still excludes **/tsp.exe from BinSkim, leaving the published executable unscanned despite the emitter CI change.
1 open issue
What changed in this PR
This PR aims to restore BinSkim scanning for tsp.exe now that the upstream Node.js issue is resolved.
Changes:
- Removes the
tsp.exeexclusion from the common CI pipeline’s BinSkim targets. - Removes the accompanying workaround comment and issue link.
| File | Description |
|---|---|
eng/common/pipelines/ci.yml |
Includes all DLL and EXE files in BinSkim targets without excluding tsp.exe. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Removing the publishing exclusion requires BinSkim validation of the actual Node 26-based tsp.exe because Node.js #42100 added only an opt-in CFG build option, not CFG-enabled release binaries.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
|
You can try these changes here
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.