Skip to content

Reenable binskim for tsp.exe as node issue was resolved #12508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Timothee Guerin (timotheeguerin) wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Reenable binskim for tsp.exe as node issue was resolved #12508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adde4a7
Reenable as node issue was resolved
timotheeguerin Nov 5, 2026
c7bad7a
Merge branch 'main' into reenable-tsp-exe-binskinm
timotheeguerin Nov 9, 2026
0e59ada
ci: enable BinSkim for the published CLI
timotheeguerin Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/common/pipelines/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extends:
template: /eng/common/pipelines/templates/1es-redirect.yml
parameters:
BinSkimSettings:
analyzeTargetGlob: +:file|**/*.dll;+:file|**/*.exe;-:f|**/tsp.exe # Flag issue with node binary which we can't fix https://github.com/nodejs/node/issues/42100
analyzeTargetGlob: +:file|**/*.dll;+:file|**/*.exe
Comment thread
timotheeguerin marked this conversation as resolved.
Resolved
stages:
- stage: InitStage
displayName: Initialize
Expand Down
2 changes: 1 addition & 1 deletion eng/tsp-core/pipelines/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ extends:
template: /eng/common/pipelines/templates/1es-redirect.yml
parameters:
BinSkimSettings:
analyzeTargetGlob: +:file|*.exe;-:f|**/tsp.exe # Flag issue with node binary which we can't fix https://github.com/nodejs/node/issues/42100
analyzeTargetGlob: +:file|*.exe
variables:
- template: /eng/tsp-core/pipelines/templates/variables/globals.yml@self

Expand Down
Loading