Repository navigation
fix: make test-verifier read the story ACs and the test bodies (#451) - #452
Merged
Merged
Conversation
Owner
Author
Review of #452Approved (comment only; this is the owner's own PR, so no approval badge is possible). Checked against the acceptance criteria on #451.
No Must fix or Should fix. One nit, left as is: the examples now read No tests apply (agent prompt change). CI was still running when I reviewed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451. Part of the #400 pipeline audit; folded into the final PR to
main.Edits
.claude/agents/test-verifier.mdonly:story.md, read in full first; build reports are not evidence of coverage.NOT COVERED.UNTESTABLEandNOT COVEREDare allowed as unverified outcomes, each with a reason.Frontmatter checked with
js-yaml: parses, description still double-quoted. No tests apply (agent prompt change only). Restart the session to load the updated agent.