Skip to content

fix: make test-verifier read the story ACs and the test bodies (#451) - #452

Merged
nevridge merged 1 commit into
feature/pipeline-mergefrom
fix/451-test-verifier-read-story
Nov 8, 2026
Merged

nevridge merged 1 commit into
feature/pipeline-mergefrom
fix/451-test-verifier-read-story

Conversation

@nevridge

@nevridge nevridge commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Closes #451. Part of the #400 pipeline audit; folded into the final PR to main.

Edits .claude/agents/test-verifier.md only:

  • AC and edge-case numbering comes from story.md, read in full first; build reports are not evidence of coverage.
  • Each covered AC names the test file and test name relied on, and the reply states which test bodies were opened; otherwise the AC is NOT COVERED.
  • Only UNTESTABLE and NOT COVERED are allowed as unverified outcomes, each with a reason.

Frontmatter checked with js-yaml: parses, description still double-quoted. No tests apply (agent prompt change only). Restart the session to load the updated agent.

@nevridge

nevridge commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

Review of #452

Approved (comment only; this is the owner's own PR, so no approval badge is possible). Checked against the acceptance criteria on #451.

  1. AC list from the story: met. Step 1 reads story.md in full, numbers the ACs as it does, calls it the only source, and says build-*.md reports are not evidence of coverage.
  2. Citations: met. Step 3 and the Reply section require each covered AC to name the test file and test name, and the reply to list the bodies opened. A credit without a named, opened test is NOT COVERED.
  3. Unverified outcomes: met. Only UNTESTABLE and NOT COVERED, each with a reason; "not verified" because the story was not read is ruled out.
  4. Frontmatter: the diff does not touch lines 1-7. I loaded the PR branch's file with js-yaml and it parses (name: test-verifier, model: sonnet, description a string, tools intact).
  5. Scope: one file, 3 lines changed, based on feature/pipeline-merge.

No Must fix or Should fix. One nit, left as is: the examples now read File.Test.Name, which does not say whether that is a path plus a test name or a class-qualified name. A literal reading still gives a usable citation.

No tests apply (agent prompt change). CI was still running when I reviewed: assistant and lint had passed, build, test and taskflow-web were pending. Merge when those are green, then close #451 by hand (a merge into a non-default branch does not close it). Restart the session to load the updated agent.

@nevridge
nevridge merged commit 51bc639 into feature/pipeline-merge Nov 8, 2026
12 checks passed
@nevridge
nevridge deleted the fix/451-test-verifier-read-story branch November 8, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant