Skip to content

chore: merge the API, web and MCP feature-factory pipelines (#400) - #453

Merged
nevridge merged 11 commits into
mainfrom
feature/pipeline-merge
Nov 8, 2026
Merged

nevridge merged 11 commits into
mainfrom
feature/pipeline-merge

Conversation

@nevridge

@nevridge nevridge commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Closes #400. Merges the API, web and MCP feature-factory pipelines into one. Sub-issue A (#436, rules, settings and hooks) already merged to main in #439; B, C and two follow-ups were built and reviewed on feature/pipeline-merge and land here together.

What changes

17 files, +302 / -1549. Prompt, agent and docs files only; no application code.

Verification

Not verified

Review notes

No tests apply: agent prompts, a skill and docs. CodeQL, the Docker scan and dependency review run only on PRs to main, so this is their first run for these changes. Review is required.

…, ux-planner dependency proposals, verifier path)
chore: consolidate the feature-factory agents into seven in root .claude/agents
chore: replace the two feature-factory skills with one orchestrator skill
fix: quote description frontmatter in four agents (#448)
fix: make test-verifier read the story ACs and the test bodies (#451)
- feature-factory: send verifier code failures to the builder in Correct and Halt when a gate is still failing after the budget
- feature-factory: drop the nonexistent TaskFlow.Contracts from the validator checklist

@nevridge nevridge left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: 💬 Comments

This PR cleanly consolidates the three pipelines into one orchestrator skill and seven project agents, with no application code touched. Two small gaps in the new feature-factory skill were found in review and fixed in the follow-up commit.

# Severity Location Finding Status
1 🟠 Important .claude/skills/feature-factory/SKILL.md:77 Verifier code failures are routed to Correct but never forwarded to a builder, and Halt ignores a still-failing gate ✅ Fixed in 4c5ee84
2 ⚪ Nit .claude/skills/feature-factory/SKILL.md:73 Validator checklist names TaskFlow.Contracts, which does not exist ✅ Fixed in 4c5ee84

Fixes pushed

Commit 4c5ee84 addresses: [1], [2]


Reviewed at 4c5ee84 · findings from pr-review + code-review, verified and triaged by @nevridge with Claude Code

@nevridge
nevridge merged commit 086bdc4 into main Nov 8, 2026
17 checks passed
@nevridge
nevridge deleted the feature/pipeline-merge branch November 8, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: merge the API, web and MCP feature-factory pipelines

1 participant