Repository navigation
chore: merge the API, web and MCP feature-factory pipelines (#400) - #453
Merged
Merged
Conversation
…, ux-planner dependency proposals, verifier path)
chore: consolidate the feature-factory agents into seven in root .claude/agents
…EADME feature-factory paragraph)
chore: replace the two feature-factory skills with one orchestrator skill
fix: quote description frontmatter in four agents (#448)
fix: make test-verifier read the story ACs and the test bodies (#451)
- feature-factory: send verifier code failures to the builder in Correct and Halt when a gate is still failing after the budget - feature-factory: drop the nonexistent TaskFlow.Contracts from the validator checklist
nevridge
commented
Nov 8, 2026
nevridge
left a comment
Owner
Author
There was a problem hiding this comment.
Review: 💬 Comments
This PR cleanly consolidates the three pipelines into one orchestrator skill and seven project agents, with no application code touched. Two small gaps in the new feature-factory skill were found in review and fixed in the follow-up commit.
| # | Severity | Location | Finding | Status |
|---|---|---|---|---|
| 1 | 🟠 Important | .claude/skills/feature-factory/SKILL.md:77 |
Verifier code failures are routed to Correct but never forwarded to a builder, and Halt ignores a still-failing gate | ✅ Fixed in 4c5ee84 |
| 2 | ⚪ Nit | .claude/skills/feature-factory/SKILL.md:73 |
Validator checklist names TaskFlow.Contracts, which does not exist |
✅ Fixed in 4c5ee84 |
Fixes pushed
Commit 4c5ee84 addresses: [1], [2]
Reviewed at 4c5ee84 · findings from pr-review + code-review, verified and triaged by @nevridge with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #400. Merges the API, web and MCP feature-factory pipelines into one. Sub-issue A (#436, rules, settings and hooks) already merged to
mainin #439; B, C and two follow-ups were built and reviewed onfeature/pipeline-mergeand land here together.What changes
.claude/agents/, allmodel: sonnet:backend-builder,frontend-builder,assistant-builder,test-verifier,implementation-validator,claude-integration-advisor,ux-advisor. Theassistant/.claude/agents (six files) and its separatefeature-factoryskill are removed.ux-plannernow points atux-advisor.feature-factoryskill in.claude/skills/feature-factory/replaces the two. Stages: preflight, research, story (stop 1, skipped for groomed issues), brief (stop 2, with the UX and Claude-integration advisors when the Scope block calls for them), build (api, web, assistant; one commit each), verify, validate, correct (shared budget of 2, respec budget of 1), finish. Run state lives in.feature-factory/<issue-or-slug>/(gitignored) and survives a restart. Finish posts an<!-- implementation-notes -->comment and opens the PR.:in thedescription:frontmatter made the file invalid YAML. Descriptions are now double-quoted.test-verifiertakes the AC list fromstory.md, cites the test and name behind every covered AC, and may only reportUNTESTABLEorNOT COVEREDas unverified.assistant/README.md: one line updated for the new pipeline.17 files, +302 / -1549. Prompt, agent and docs files only; no application code.
Verification
assistantwith a reason, both advisors behaved as designed, and the notes comment had its five sections. It surfaced fix: four project agents do not register (unquoted colon in description frontmatter) #448 and the fix: make test-verifier read the story ACs and the test bodies #451 gap, both fixed here. Result: chore: replace the two feature-factory skills with one orchestrator skill #438 (comment)js-yaml.Not verified
Review notes
No tests apply: agent prompts, a skill and docs. CodeQL, the Docker scan and dependency review run only on PRs to
main, so this is their first run for these changes. Review is required.