Repository navigation
fix: Preserve card description/due date on cloning - #7345
Open
juliusknorr wants to merge 4 commits into
Open
juliusknorr wants to merge 4 commits into
juliusknorr wants to merge 4 commits into
Conversation
juliusknorr
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
November 7, 2025 12:38
juliusknorr
changed the title
luka-nextcloud
requested changes
Jan 14, 2026
| } | ||
| $this->permissionService->checkPermission($this->stackMapper, $targetStackId, Acl::PERMISSION_EDIT); | ||
| $newCard = $this->create($originCard->getTitle(), $targetStackId, $originCard->getType(), $originCard->getOrder(), $originCard->getOwner()); | ||
| $newCard = $this->create($originCard->getTitle(), $targetStackId, $originCard->getType(), $originCard->getOrder(), $originCard->getOwner(), $originCard->getDescription(), $originCard->getD()); |
Contributor
There was a problem hiding this comment.
Function getDuedate() should be used instead of getD()
juliusknorr
force-pushed
the
fix/clone-description
branch
from
January 28, 2026 20:05
18d0e5f to
57ff2e3
Compare
juliusknorr
force-pushed
the
fix/clone-description
branch
from
March 17, 2026 12:13
57ff2e3 to
78679d7
Compare
Signed-off-by: Julius Knorr <jus@bitgrid.net> Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Julius Knorr <jus@bitgrid.net> Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/clone-description
branch
from
November 11, 2026 14:10
78679d7 to
78af9a7
Compare
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Julius Knorr <jus@bitgrid.net>
Member
Author
|
getDuedate() is used, the due date is now passed to create() so the clone keeps it, and the start date too. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit fixes the wrapped CardDetails entity: we proxied getters and setters to the internal card object but not getUpdatedFields, so changes made through a CardDetails instance were not detected as updates.
The second commit sets the description and due date directly when creating the cloned card. The description was meanwhile also fixed on main by refetching the card before the update (51afd22), but the due and start dates were still lost on clone.
Rebased onto main (keeps the cloned card color) and added regression tests for both.