Skip to content

fix: Preserve card description/due date on cloning #7345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliusknorr wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Preserve card description/due date on cloning #7345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3efb9d7
fix: Pass getUpdatedFields to internal card entity
juliusknorr Nov 7, 2025
7179572
fix: Set description and due date on create
juliusknorr Nov 7, 2025
78af9a7
test: Cover description and due date on card clone
juliusknorr Nov 11, 2026
c631d75
fix: Keep the start date on card clone
juliusknorr Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/Model/CardDetails.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,9 @@ protected function getter(string $name): mixed {
public function __call(string $methodName, array $args) {
return $this->card->__call($methodName, $args);
}

#[\Override]
public function getUpdatedFields(): array {
return $this->card->getUpdatedFields();
}
}
2 changes: 1 addition & 1 deletion lib/Service/CardService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ public function cloneCard(int $id, ?int $targetStackId = null):Card {
$targetStackId = $originCard->getStackId();
}
$this->permissionService->checkPermission($this->stackMapper, $targetStackId, Acl::PERMISSION_EDIT);
$newCard = $this->create($originCard->getTitle(), $targetStackId, $originCard->getType(), $originCard->getOrder(), $originCard->getOwner(), color: $originCard->getColor());
$newCard = $this->create($originCard->getTitle(), $targetStackId, $originCard->getType(), $originCard->getOrder(), $originCard->getOwner(), description: $originCard->getDescription(), duedate: $originCard->getDuedate(), startdate: $originCard->getStartdate(), color: $originCard->getColor());
$boardId = $this->stackMapper->findBoardId($targetStackId);
foreach ($this->labelMapper->findAssignedLabelsForCard($id) as $label) {
if ($boardId !== $this->stackMapper->findBoardId($originCard->getStackId())) {
Expand Down
8 changes: 8 additions & 0 deletions tests/unit/Db/CardTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,4 +172,12 @@ public function testJsonSerializeAsignedUsers() {
'color' => 'ffffff',
], (new CardDetails($card))->jsonSerialize());
}

public function testCardDetailsForwardsUpdatedFields(): void {
$card = $this->createCard();
$card->resetUpdatedFields();
$details = new CardDetails($card);
$details->setDescription('changed');
$this->assertEquals(['description' => true], $details->getUpdatedFields());
}
}
5 changes: 5 additions & 0 deletions tests/unit/Service/CardServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,8 @@ public function testClone() {
$card->setStackId(12345);
$card->setDescription('A test description');
$card->setColor('FF0000');
$card->setDuedate(new \DateTime('2026-12-24 12:00:00'));
$card->setStartdate(new \DateTime('2026-12-20 09:00:00'));

$clonedCard = clone $card;
$clonedCard->setId(2);
Expand Down Expand Up @@ -414,6 +416,9 @@ public function testClone() {

$this->assertEquals('A test description', $c->getDescription());
$this->assertEquals('FF0000', $inserted[1]->getColor());
$this->assertEquals('A test description', $inserted[1]->getDescription());
$this->assertEquals($card->getDuedate(), $inserted[1]->getDuedate());
$this->assertEquals($card->getStartdate(), $inserted[1]->getStartdate());

$this->assertCount(1, $c->getLabels());
$this->assertEquals($label->getId(), $c->getLabels()[0]->getId());
Expand Down
Loading