Repository navigation
chore: put the lockfile back in sync for npm 8 - #659
Conversation
npm ci has failed on Node 16 since the release-notes tool moved to 5.1.1: npm 8 resolves an optional peer dependency on @types/node that the lockfile had no entry for. Add the two entries npm 8 expects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
=======================================
Coverage 86.36% 86.36%
=======================================
Files 9 9
Lines 1283 1283
Branches 335 335
=======================================
Hits 1108 1108
Misses 100 100
Partials 75 75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
npm cihas failed on Node 16 since #651, so CI onmasteris red and so is every open pull request. The Node 16 job fails first and the matrix cancels the rest, which is why all six test jobs show as failed.Cause
#651 moved
@cjbarth/github-release-notesto 5.1.1, whose@inquirer/*packages have an optional peer dependency on@types/node >=18. The root's@types/nodeis 16, which doesn't satisfy that. npm 8, 9 and 10 resolve the optional peer with a nested@types/node@26.6.5and expect it in the lockfile. npm 11 leaves an unmet optional peer unresolved and writes no entry, which is the lockfile #651 has. The Node 16 job, which runs npm 8, is the one that fails first.Fix
The two entries npm 8 asks for, added by
npm@8.19.4 install --package-lock-only. Both aredev,optionalandpeer, and nothing else in the lockfile changes.npm ci --dry-run:npm ci && npm run build && npm testalso passes locally on Node 26 with npm 11.This comes back if npm 11 rewrites the lockfile.
npm installwith npm 11 removes the two entries again, and npm 10 and older then refuse it. For as long as CI has a job that runs npm 10 or older, a lockfile change in a pull request needs them kept, or re-added with the command above.Once this merges, re-running the checks on an open pull request picks it up, since they run on the merge with
master.🤖 Generated with Claude Code