Skip to content

Add localization support for game events, settings, and UI text elements - #1372

Merged
evanpelle merged 3 commits into
openfrontio:mainfrom
TomaszOleszko:main
Jul 8, 2025
Merged

evanpelle merged 3 commits into
openfrontio:mainfrom
TomaszOleszko:main

Conversation

@TomaszOleszko

Copy link
Copy Markdown
Contributor

Description:

This PR adds missing translations for various UI components, including game events and settings. No visual changes were made, so screenshots are not required. All user-facing text has been properly localized and added to the en.json file.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
  • I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

Please put your Discord username so you can be contacted if a bug or regression is found:

pierogi69

@coderabbitai

coderabbitai Bot commented Jul 8, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

This update replaces hardcoded English UI strings with localized text using translation keys across various client-side components. New keys are added to the English language file to support these translations, covering UI labels, event messages, settings, and prompts. No logic or control flow is changed—only the displayed text is now localized.

Changes

File(s) Change Summary
resources/lang/en.json Added many new localization keys for UI labels, settings, events, and prompts.
src/client/graphics/layers/EventsDisplay.ts Replaced hardcoded English event and UI texts with translateText calls for localization.
src/client/graphics/layers/GameRightSidebar.ts,
src/client/graphics/layers/OptionsMenu.ts
Changed exit confirmation prompt to use localized text via translateText.
src/client/graphics/layers/ReplayPanel.ts Changed fastest replay speed label from static "max" to localized string.
src/client/graphics/layers/SettingsModal.ts Replaced all hardcoded settings labels and descriptions with translation keys; updated import path.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI_Component
    participant translateText
    participant en.json

    User->>UI_Component: Triggers UI action (e.g., open settings, event occurs)
    UI_Component->>translateText: Request translation with key
    translateText->>en.json: Fetch localized string
    en.json-->>translateText: Return localized string
    translateText-->>UI_Component: Localized string
    UI_Component-->>User: Display localized text
Loading

Possibly related PRs

  • mls 4.0 #1336: Also expands localization keys and updates UI text to use translation functions, sharing the goal of enhancing UI internationalization.
  • Move settings to it's own modal #1366: Restructures the settings UI into a modal component, related by UI settings context but does not modify localization keys or translation calls.

Suggested labels

Translation - Revision

Suggested reviewers

  • evanpelle

Poem

🌍
Strings once plain, now dance and sing,
In every menu, prompt, and setting—
With keys unlocked, translations bring
A world of words for all to see.
Goodbye to hardcode, hello to spree!
Now every click speaks globally.
🌐


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9fefbe8 and 8b1a226.

📒 Files selected for processing (1)
  • resources/lang/en.json (6 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • resources/lang/en.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: 🏗️ Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cbe34e and 1e41332.

📒 Files selected for processing (6)
  • resources/lang/en.json (6 hunks)
  • src/client/graphics/layers/EventsDisplay.ts (10 hunks)
  • src/client/graphics/layers/GameRightSidebar.ts (2 hunks)
  • src/client/graphics/layers/OptionsMenu.ts (2 hunks)
  • src/client/graphics/layers/ReplayPanel.ts (1 hunks)
  • src/client/graphics/layers/SettingsModal.ts (9 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: andrewNiziolek
PR: openfrontio/OpenFrontIO#1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
Learnt from: scottanderson
PR: openfrontio/OpenFrontIO#949
File: resources/lang/en.json:8-10
Timestamp: 2025-05-30T03:53:52.231Z
Learning: For the OpenFrontIO project, do not suggest updating translation files in resources/lang/*.json except for en.json. The project has a dedicated translation team that handles all other locale files.
Learnt from: andrewNiziolek
PR: openfrontio/OpenFrontIO#1007
File: resources/lang/he.json:138-138
Timestamp: 2025-06-02T14:27:23.893Z
Learning: andrewNiziolek's project uses community translation for internationalization. When updating map names or other user-facing text, they update the keys programmatically but wait for community translators to provide accurate translations in each language rather than using machine translations.
Learnt from: VariableVince
PR: openfrontio/OpenFrontIO#959
File: resources/maps/Japan.json:31-35
Timestamp: 2025-05-30T18:11:20.372Z
Learning: Nation names on maps in OpenFrontIO are not localized/translated. They are displayed directly without using the translateText() function or requiring entries in localization files like resources/lang/en.json.
src/client/graphics/layers/GameRightSidebar.ts (1)
Learnt from: VariableVince
PR: openfrontio/OpenFrontIO#1110
File: src/client/Main.ts:293-295
Timestamp: 2025-06-09T02:20:43.637Z
Learning: In src/client/Main.ts, during game start in the handleJoinLobby callback, UI elements are hidden using direct DOM manipulation with classList.add("hidden") for consistency. This includes modals, buttons, and error divs. The codebase follows this pattern rather than using component APIs for hiding elements during game transitions.
src/client/graphics/layers/OptionsMenu.ts (2)
Learnt from: VariableVince
PR: openfrontio/OpenFrontIO#1110
File: src/client/Main.ts:293-295
Timestamp: 2025-06-09T02:20:43.637Z
Learning: In src/client/Main.ts, during game start in the handleJoinLobby callback, UI elements are hidden using direct DOM manipulation with classList.add("hidden") for consistency. This includes modals, buttons, and error divs. The codebase follows this pattern rather than using component APIs for hiding elements during game transitions.
Learnt from: devalnor
PR: openfrontio/OpenFrontIO#1195
File: src/client/graphics/layers/AlertFrame.ts:18-18
Timestamp: 2025-06-20T20:11:00.965Z
Learning: In the OpenFrontIO codebase, UserSettings instances are created directly with `new UserSettings()` in each component that needs them. This pattern is used consistently across at least 12+ files including OptionsMenu, EventsDisplay, DarkModeButton, Main, UserSettingModal, UsernameInput, NameLayer, AlertFrame, UILayer, InputHandler, ClientGameRunner, and GameView. This is the established architectural pattern and should be followed for consistency.
src/client/graphics/layers/SettingsModal.ts (5)
Learnt from: VariableVince
PR: openfrontio/OpenFrontIO#1110
File: src/client/Main.ts:293-295
Timestamp: 2025-06-09T02:20:43.637Z
Learning: In src/client/Main.ts, during game start in the handleJoinLobby callback, UI elements are hidden using direct DOM manipulation with classList.add("hidden") for consistency. This includes modals, buttons, and error divs. The codebase follows this pattern rather than using component APIs for hiding elements during game transitions.
Learnt from: andrewNiziolek
PR: openfrontio/OpenFrontIO#1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
Learnt from: scottanderson
PR: openfrontio/OpenFrontIO#786
File: src/client/TerritoryPatternsModal.ts:337-338
Timestamp: 2025-06-22T05:48:19.241Z
Learning: In src/client/TerritoryPatternsModal.ts, the bit shifting operators (<<) used in coordinate calculations with decoder.getScale() are intentional and should not be changed to multiplication. The user scottanderson confirmed this is functioning as intended.
Learnt from: devalnor
PR: openfrontio/OpenFrontIO#1195
File: src/client/graphics/layers/AlertFrame.ts:18-18
Timestamp: 2025-06-20T20:11:00.965Z
Learning: In the OpenFrontIO codebase, UserSettings instances are created directly with `new UserSettings()` in each component that needs them. This pattern is used consistently across at least 12+ files including OptionsMenu, EventsDisplay, DarkModeButton, Main, UserSettingModal, UsernameInput, NameLayer, AlertFrame, UILayer, InputHandler, ClientGameRunner, and GameView. This is the established architectural pattern and should be followed for consistency.
Learnt from: devalnor
PR: openfrontio/OpenFrontIO#1195
File: src/client/graphics/layers/AlertFrame.ts:18-18
Timestamp: 2025-06-20T20:11:00.965Z
Learning: In the OpenFrontIO codebase, UserSettings instances are created directly with `new UserSettings()` in components like OptionsMenu, EventsDisplay, and AlertFrame. This is the established pattern and should be followed for consistency rather than using dependency injection.
src/client/graphics/layers/EventsDisplay.ts (3)
Learnt from: andrewNiziolek
PR: openfrontio/OpenFrontIO#1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
Learnt from: VariableVince
PR: openfrontio/OpenFrontIO#1110
File: src/client/Main.ts:293-295
Timestamp: 2025-06-09T02:20:43.637Z
Learning: In src/client/Main.ts, during game start in the handleJoinLobby callback, UI elements are hidden using direct DOM manipulation with classList.add("hidden") for consistency. This includes modals, buttons, and error divs. The codebase follows this pattern rather than using component APIs for hiding elements during game transitions.
Learnt from: VariableVince
PR: openfrontio/OpenFrontIO#959
File: resources/maps/Japan.json:31-35
Timestamp: 2025-05-30T18:11:20.372Z
Learning: Nation names on maps in OpenFrontIO are not localized/translated. They are displayed directly without using the translateText() function or requiring entries in localization files like resources/lang/en.json.
resources/lang/en.json (2)
Learnt from: andrewNiziolek
PR: openfrontio/OpenFrontIO#1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
Learnt from: scottanderson
PR: openfrontio/OpenFrontIO#949
File: resources/lang/en.json:8-10
Timestamp: 2025-05-30T03:53:52.231Z
Learning: For the OpenFrontIO project, do not suggest updating translation files in resources/lang/*.json except for en.json. The project has a dedicated translation team that handles all other locale files.
🧬 Code Graph Analysis (2)
src/client/graphics/layers/ReplayPanel.ts (1)
src/client/LangSelector.ts (1)
  • translateText (231-251)
src/client/graphics/layers/SettingsModal.ts (1)
src/client/LangSelector.ts (1)
  • translateText (231-251)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: 🏗️ Build
🔇 Additional comments (26)
src/client/graphics/layers/ReplayPanel.ts (1)

77-80: LGTM! Localization correctly implemented.

The change properly replaces the hardcoded "max" string with a localized version using translateText("replay_panel.fastest_game_speed"). The implementation is clean and follows the established pattern.

Note: The other speed buttons still use hardcoded strings like "×0.5", "×1", "×2", which is likely intentional since numeric multipliers typically don't need translation.

src/client/graphics/layers/OptionsMenu.ts (2)

10-10: LGTM! Import added correctly.

The translateText import is properly added from the Utils module.


78-80: LGTM! Exit confirmation localized correctly.

The hardcoded confirmation message is properly replaced with translateText("help_modal.exit_confirmation"). This follows the correct localization pattern and uses a shared key that can be reused across components.

src/client/graphics/layers/GameRightSidebar.ts (2)

14-14: LGTM! Import added correctly.

The translateText import is properly added from the Utils module.


90-92: LGTM! Consistent exit confirmation localization.

The exit confirmation is properly localized using the same key "help_modal.exit_confirmation" as used in OptionsMenu.ts. This ensures consistent messaging across components.

src/client/graphics/layers/EventsDisplay.ts (7)

268-298: LGTM! Alliance expiration handling properly localized.

The alliance expiration messages and buttons are correctly localized with proper parameter substitution using {name} placeholders. The logic remains intact while making all user-facing text translatable.


415-452: LGTM! Alliance request events properly localized.

The alliance request descriptions and button texts are correctly localized using appropriate keys like "events_display.request_alliance", "events_display.focus", "events_display.accept_alliance", and "events_display.reject_alliance".


466-478: LGTM! Alliance request status properly localized.

The alliance request reply handling correctly uses conditional translation for accepted/rejected status, maintaining the dynamic nature while making it translatable.


497-533: LGTM! Betrayal events properly localized.

The betrayal duration calculation and messages are correctly localized with proper parameter substitution. The logic for singular vs plural duration text is properly handled with separate translation keys.


620-638: LGTM! Emoji message formatting improved.

The emoji message formatting is correctly localized and improved with proper spacing. Both direct emoji messages and sent emoji notifications are properly handled.


768-768: LGTM! Wilderness text localized.

The "Wilderness" text for land attacks is properly localized using "help_modal.ui_wilderness" key.


975-975: LGTM! Hide button localized.

The "Hide" button text is properly localized using "leaderboard.hide" key.

src/client/graphics/layers/SettingsModal.ts (9)

14-14: LGTM! Import path corrected.

The import path for translateText is correctly updated from "../../../client/Utils" to "../../Utils" to match the proper relative path.


146-148: LGTM! Settings header localized.

The settings modal title is properly localized using "user_setting.tab_basic" key.


165-178: LGTM! Terrain toggle properly localized.

The terrain toggle setting label and status descriptions are correctly localized with appropriate conditional text for enabled/disabled states.


188-200: LGTM! Emojis setting properly localized.

The emojis setting label and conditional status text are correctly localized using appropriate keys for visible/hidden states.


215-227: LGTM! Dark mode setting properly localized.

The dark mode setting is correctly localized with appropriate conditional text for dark/light mode states.


242-254: LGTM! Special effects setting properly localized.

The special effects setting label and status descriptions are correctly localized with proper conditional text.


264-276: LGTM! Anonymous names setting properly localized.

The anonymous names setting is correctly localized with appropriate conditional text for showing anonymous vs real names.


285-298: LGTM! Left click menu setting properly localized.

The left click menu setting label and status descriptions are correctly localized with proper conditional text for left vs right click behavior.


308-313: LGTM! Exit game section properly localized.

The exit game button label and description are correctly localized using appropriate keys.

resources/lang/en.json (5)

270-276: Stick to a consistent enabled/disabled pair

For anonymous-names we have
anonymous_names_enabled ↔︎ real_names_shown.
This breaks the {feature}_{enabled|disabled} pattern used elsewhere (dark_mode, special_effects, terrain).

Recommend renaming the “off” string to keep symmetry:

-    "real_names_shown": "Real names shown",
+    "anonymous_names_disabled": "Real names shown",

This makes code that toggles the flag far simpler (no special-case mapping).
[ suggest_optional_refactor ]


279-280: Redundant key

left_click_menu and left_click_opens_menu hold identical information.
Unless one is legacy, drop the shorter alias to avoid translators having to keep two strings in sync.
[ suggest_nitpick ]


322-329: UI copy: capitalisation & clarity

"exit_game_info": "Return to main menu" is action text, not information.
Consider imperative form to match other labels:

-    "exit_game_info": "Return to main menu"
+    "exit_game_info": "Return to the main menu"

Minor wording tweak improves readability for non-native speakers.
[ suggest_nitpick ]


460-466: Pluralisation keys could be clearer

duration_second vs duration_seconds_plural is hard to auto-select.
Typical i18n libraries expect {count, plural, one{…} other{…}}.
If you must keep separate keys, make them symmetrical:

-    "duration_second": "1 second",
-    "duration_seconds_plural": "{seconds} seconds",
+    "duration_seconds_one": "1 second",
+    "duration_seconds_other": "{seconds} seconds",

This plays nicely with ICU plural rules and future translators.
[ suggest_optional_refactor ]


520-521: Label may confuse users

"fastest_game_speed": "max" is terse; UI labels usually use “Fastest”.
Consider:

-    "fastest_game_speed": "max"
+    "fastest_game_speed": "Fastest"

Short, clear, no jargon.
[ suggest_nitpick ]

Comment thread resources/lang/en.json Resolved
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Jul 8, 2025
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
resources/lang/en.json (2)

272-276: Good, but double-check plural wording
special_effects_enabled/disabled and anonymous_names_enabled match the established tense. Consider changing real_names_shown → real_names_visible for symmetry, but that’s optional.


322-329: Exit-related strings OK, but naming could shorten
exit_game_info could be exit_game_desc to align with other *_desc names. Not blocking.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e41332 and 9fefbe8.

📒 Files selected for processing (1)
  • resources/lang/en.json (6 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: andrewNiziolek
PR: openfrontio/OpenFrontIO#1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
Learnt from: scottanderson
PR: openfrontio/OpenFrontIO#949
File: resources/lang/en.json:8-10
Timestamp: 2025-05-30T03:53:52.231Z
Learning: For the OpenFrontIO project, do not suggest updating translation files in resources/lang/*.json except for en.json. The project has a dedicated translation team that handles all other locale files.
Learnt from: andrewNiziolek
PR: openfrontio/OpenFrontIO#1007
File: resources/lang/he.json:138-138
Timestamp: 2025-06-02T14:27:23.893Z
Learning: andrewNiziolek's project uses community translation for internationalization. When updating map names or other user-facing text, they update the keys programmatically but wait for community translators to provide accurate translations in each language rather than using machine translations.
Learnt from: VariableVince
PR: openfrontio/OpenFrontIO#959
File: resources/maps/Japan.json:31-35
Timestamp: 2025-05-30T18:11:20.372Z
Learning: Nation names on maps in OpenFrontIO are not localized/translated. They are displayed directly without using the translateText() function or requiring entries in localization files like resources/lang/en.json.
resources/lang/en.json (2)
Learnt from: andrewNiziolek
PR: openfrontio/OpenFrontIO#1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
Learnt from: scottanderson
PR: openfrontio/OpenFrontIO#949
File: resources/lang/en.json:8-10
Timestamp: 2025-05-30T03:53:52.231Z
Learning: For the OpenFrontIO project, do not suggest updating translation files in resources/lang/*.json except for en.json. The project has a dedicated translation team that handles all other locale files.
🪛 Biome (1.9.4)
resources/lang/en.json

[error] 261-261: Minus must be followed by a digit

(parse)


[error] 261-261: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 261-261: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 261-261: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 261-262: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 262-262: unexpected character +

(parse)


[error] 262-262: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 262-262: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 262-262: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 262-263: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 263-263: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 263-263: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 263-263: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 263-264: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 264-264: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 264-264: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 264-264: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 264-265: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 265-265: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 265-265: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 265-265: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 265-266: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 266-266: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 266-266: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 266-266: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 266-267: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 267-267: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 267-267: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 267-267: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 267-268: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 268-268: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 268-268: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 268-268: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 268-269: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 269-269: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 269-269: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 269-269: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 269-270: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 270-270: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 270-270: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 270-270: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 270-271: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 271-271: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 271-271: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 271-271: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 271-272: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 272-272: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 272-272: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 272-272: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 272-273: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 273-273: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 273-273: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 273-273: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 273-274: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 274-274: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 274-274: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 274-274: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 274-275: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 275-275: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 275-275: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 275-275: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 275-276: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 276-276: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 276-276: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 276-276: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 276-277: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 277-277: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 277-277: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 277-277: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 277-278: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 278-278: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 278-278: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 278-278: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 278-279: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 279-279: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 279-279: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 279-279: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 279-280: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 280-280: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 280-280: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 280-280: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 280-281: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 281-281: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 281-281: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 281-281: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 322-322: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 322-322: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 322-322: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 322-322: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 323-323: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 323-323: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 323-324: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 324-324: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 324-324: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 324-324: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 324-325: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 325-325: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 325-325: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 325-325: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 325-325: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 325-325: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 325-326: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 326-326: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 326-326: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 326-326: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 326-326: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 326-326: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 326-327: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 327-327: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 327-327: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 327-327: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 327-328: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 328-328: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 328-329: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 329-329: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 329-329: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 329-329: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)


[error] 329-329: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: 🔬 Test
  • GitHub Check: 🏗️ Build
🔇 Additional comments (6)
resources/lang/en.json (6)

63-63: Key addition looks good
ui_wilderness fits the naming convention and the value is clear. No further action.


116-117: Consistent additions
Both info_enemy_panel and exit_confirmation follow the existing pattern and do not clash with any known keys.


264-266: Verify downstream usage of new emoji keys
New keys emojis_visible / emojis_hidden replace older wording. Ensure every occurrence of the old keys has been migrated; otherwise UI will fall back to the raw key string.


280-282: Left-/Right-click wording is clear
No issues; keys align with existing UI copy style.


461-477: Comprehensive event strings added – check variable coverage
All new strings use {name}, {status}, {seconds}, {malusPercent}, {durationText}, or {target} placeholders. Make sure the calling code supplies each placeholder; otherwise runtime will show missing token text.


520-522: fastest_game_speed key is terse but clear
If the button label is limited for space, “max” works. No issues.

Comment thread resources/lang/en.json Resolved
@Aotumuri Aotumuri mentioned this pull request Jul 8, 2025
Closed
@evanpelle evanpelle added this to the v24 milestone Jul 8, 2025

@evanpelle evanpelle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation Bot moved this from Development to Final Review in OpenFront Release Management Jul 8, 2025
@evanpelle
evanpelle merged commit 4ed4c7e into openfrontio:main Jul 8, 2025
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management Jul 8, 2025
@VariableVince VariableVince mentioned this pull request Jul 23, 2025
4 tasks done
@scottanderson scottanderson added Translation Addition or modification of a language to the translations. and removed Translation - Revision labels Jul 23, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Aug 12, 2025
5 tasks done
@coderabbitai coderabbitai Bot mentioned this pull request Sep 4, 2025
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Translation Addition or modification of a language to the translations.

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants